Bug #32298 for Module-Install: build

Mon Jan 14 10:44:17 2008 LGODDARD [...] cpan.org - Ticket created

Subject:

build_recommends

Please could we have 'bulid_recommends' for use with cases such as Test::More plan skip_all

Thu Jul 17 12:36:26 2008 adamk [...] cpan.org - Correspondence added

I don't understand your argument, please restate in more detail.

Thu Jul 17 12:36:41 2008 The RT System itself - Status changed from 'new' to 'open'

Sat Jul 19 04:26:23 2008 leegee [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #32298] build_recommends
Date:	Sat, 19 Jul 2008 10:26:10 +0200
To:	bug-Module-Install [...] rt.cpan.org
From:	Lee Goddard <leegee [...] gmail.com>

Adam Kennedy via RT wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=32298 > > > I don't understand your argument, please res

It'd be nice if the client had module X to run some tests, but it is not needed by the actual PM being installed. Use of module in tests is recommended, but not recquired, since those tests catch the missing-module error and then skip_all if absent. build_requires [version 0.07] Modules listed in this section are necessary to build and install the given module, but are not necessary for regular usage of it. This is actually an important distinction - it allows for tighter control over the body of installed modules, and facilitates correct dependency checking on binary/packaged distributions of the module. build_recommends Modules listed in this section are recommended to run the test included in the given distribution, but their abscence will not prevent the module's installation. Then maybe one day there could be an install option, "Install the n missing modules, recommended for testing?" Just a thought tia Lee

Thu Mar 04 19:05:36 2010 ishigaki [...] cpan.org - Correspondence added

Hi. It looks like that these days "recommends()" is not recommended by the toolchain people as it prevents smooth installation/packaging by prompts, and I don't think it's a good idea to add extra "build_recommends" just for completeness, as plain "recommends" is usually used as if it were "build_recommends". Thoughts? On 2008-7-19 Sat 04:26:23, leegee@gmail.com wrote: Show quoted text

> Adam Kennedy via RT wrote:

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=32298 > > > > > I don't understand your argument, please res

> It'd be nice if the client had module X to run some tests, > but it is not needed by the actual PM being installed. > > Use of module in tests is recommended, but not recquired, > since those tests catch the missing-module error and then skip_all

if Show quoted text

> absent. > > build_requires > [version 0.07] > > Modules listed in this section are necessary to build and > install the given module, but are not necessary for

regular Show quoted text

> usage of it. This is actually an important distinction -

it Show quoted text

> allows for tighter control over the body of installed

modules, Show quoted text

> and facilitates correct dependency checking on binary/

packaged Show quoted text

> distributions of the module. > > build_recommends > Modules listed in this section are recommended to run the

test Show quoted text

> included in the given distribution, but their abscence will > not prevent > the module's installation. > > Then maybe one day there could be an install option, "Install the n > missing modules, recommended for testing?" > > Just a thought > > tia > Lee > >

Thu Mar 04 19:06:20 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'stalled'

Fri Mar 05 00:12:24 2010 adam [...] ali.as - Correspondence added

Subject:	Re: [rt.cpan.org #32298] build_recommends
Date:	Fri, 5 Mar 2010 16:05:11 +1100
To:	bug-Module-Install [...] rt.cpan.org
From:	Adam Kennedy <adamkennedybackup [...] gmail.com>

I'd go with ... if ( $ENV{AUTOMATED_TESTING} or $ENV{RELEASE_TESTING} ) { build_requires(...); } ... so you get good testing coverage, but it won't inconvenience the end users. Adam K On 5 March 2010 11:05, Kenichi Ishigaki via RT <bug-Module-Install@rt.cpan.org> wrote: Show quoted text

> Queue: Module-Install > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=32298 > > > Hi. It looks like that these days "recommends()" is not recommended by > the toolchain people as it prevents smooth installation/packaging by > prompts, and I don't think it's a good idea to add extra > "build_recommends" just for completeness, as plain "recommends" is > usually used as if it were "build_recommends". Thoughts? > > On 2008-7-19 Sat 04:26:23, leegee@gmail.com wrote:

>> Adam Kennedy via RT wrote:

>> > <URL: http://rt.cpan.org/Ticket/Display.html?id=32298 > >> > >> > I don't understand your argument, please res

>> It'd be nice if the client had module X to run some tests, >> but it is not needed by the actual PM being installed. >> >> Use of module in tests is recommended, but not recquired, >> since those tests catch the missing-module error and then skip_all

> if

>> absent. >> >> build_requires >> [version 0.07] >> >> Modules listed in this section are necessary to build and >> install the given module, but are not necessary for

> regular

>> usage of it. This is actually an important distinction -

> it

>> allows for tighter control over the body of installed

> modules,

>> and facilitates correct dependency checking on binary/

> packaged

>> distributions of the module. >> >> build_recommends >> Modules listed in this section are recommended to run the

> test

>> included in the given distribution, but their abscence will >> not prevent >> the module's installation. >> >> Then maybe one day there could be an install option, "Install the n >> missing modules, recommended for testing?" >> >> Just a thought >> >> tia >> Lee >> >>

> > > >

Fri Mar 05 00:12:26 2010 The RT System itself - Status changed from 'stalled' to 'open'

Fri Mar 05 02:40:29 2010 LGODDARD [...] cpan.org - Correspondence added

I guess so, it just means that we're installing modules for the sake of testing alone. Personally, I like lots of testing, especially important for me in a production environment where the install is automated. But yes, of course, there are plenty of work-arounds. Thanks for the consideration. -- lgoddard at cpan org http://www.LeeGoddard.net

Fri Mar 05 02:40:31 2010 LGODDARD [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #32298 for Module-Install: build_recommends