| Subject: | log strings not consistent |
Hi. In your beautiful code, I found some inconsistencies in how the log
method is called: sometimes you specify a line with trailing \n,
sometimes not. If I count correctly, 19 times with a trailing \n and 31
times without. "Without" is probably the right choice.
By the way, in your log() method, you do
my $ok = eval {
if (@therest) { # if more parameters are passed, we must assume
that the first is a format string
Sys::Syslog::syslog($level, $msg, @therest);
} else {
Sys::Syslog::syslog($level, '%s', $msg);
}
1;
};
but if Sys::Syslog is (enforced to be) recent enough (and that can be
defended very well, because there where quite some bug is older
versions), you could simply say
syslog($msg, @therest)
I think 0.19 is sufficient.