Bug #32222 for CPANPLUS: Installers should prefer Build.PL when both are available

Thu Jan 10 06:06:38 2008 schwern [...] pobox.com - Ticket created

Subject:	Installers should prefer Build.PL when both are available
Date:	Thu, 10 Jan 2008 03:05:26 -0800
To:	bug-CPANPLUS [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] pobox.com>

Since emulation will never be 100% and Module::Build's compatibility Makefile.PLs are a temporary measure to help installers which do not yet handle Module::Build, we recommend that all module installers prefer to use the Build.PL when both are available. The patch is simple enough, but I suspect that seemless Module::Build installation will have to be done (31279) before this is really viable. --- lib/CPANPLUS/Config.pm (revision 41142) +++ lib/CPANPLUS/Config.pm (local) @@ -309,11 +309,11 @@ =item prefer_makefile A boolean indicating whether or not prefer a C<Makefile.PL> over a -C<Build.PL> file if both are present. Defaults to 'true'. +C<Build.PL> file if both are present. Defaults to 'false'. =cut - $Conf->{'conf'}->{'prefer_makefile'} = 1; + $Conf->{'conf'}->{'prefer_makefile'} = 0; =item prereqs

Sun May 18 10:14:00 2008 kane [...] cpan.org - Correspondence added

On Thu Jan 10 06:06:38 2008, schwern@pobox.com wrote: Show quoted text

> Since emulation will never be 100% and Module::Build's compatibility > Makefile.PLs are a temporary measure to help installers which do not yet > handle Module::Build, we recommend that all module installers prefer to use > the Build.PL when both are available. > > The patch is simple enough, but I suspect that seemless Module::Build > installation will have to be done (31279) before this is really viable.

With 'configure_requires' support, M::B will be installed if required. We'll see how it acts in the wild and see if it's sensible to prefer Biuld.PL if possible.

Sun May 18 10:14:02 2008 The RT System itself - Status changed from 'new' to 'open'

Sun May 18 10:45:50 2008 kane [...] cpan.org - Status changed from 'open' to 'stalled'

Fri Aug 28 08:40:57 2009 CRAKRJACK [...] cpan.org - Severity Critical added

Fri Aug 28 08:42:54 2009 CRAKRJACK [...] cpan.org - Correspondence added

Module::Build 0.35 does not like the way CPANPLUS 0.88 passes along Makefile.PL arguments. It seems all the arguments are being passed in as a string instead of an array? Not 100% sure if that bug is with M::B or CP+, but if M::B::Compat is in use and M::B 0.35 is installed, a module is no longer installable by CPANPLUS.

Fri Aug 28 08:42:55 2009 The RT System itself - Status changed from 'stalled' to 'open'

Fri Aug 28 13:20:31 2009 CRAKRJACK [...] cpan.org - Correspondence added

Here's the exact error message; [MSG] Extracted 'Params::Classify' to '/.cpanplus/5.10.0/build/Params-Classify-0.007' Running [/usr/bin/perl /usr/bin/cpanp-run-perl /.cpanplus/5.10.0/build/Params-Classify-0.007/Makefile.PL INSTALLDIRS=site INSTALLSCRIPT=/usr/local/bin]... Malformed argument ' INSTALLDIRS=site INSTALLSCRIPT=/usr/local/bin' at /usr/share/perl/5.10/Module/Build/Compat.pm line 232, <DATA> line 642. [ERROR] Could not run '/usr/bin/perl Makefile.PL': Malformed argument ' INSTALLDIRS=site INSTALLSCRIPT=/usr/local/bin' at /usr/share/perl/5.10/Module/Build/Compat.pm line 232, <DATA> line 642. -- cannot continue

Fri Aug 28 14:42:02 2009 dagolden [...] cpan.org - Correspondence added

I would have it prefer Build.PL if available *without* a config option. That's what I plan to do with CPAN.pm eventually. I'll investigate the problem and see what I can find. -- David

Fri Aug 28 15:01:59 2009 dagolden [...] cpan.org - Correspondence added

On Fri Aug 28 13:20:31 2009, CRAKRJACK wrote: Show quoted text

> Malformed argument ' INSTALLDIRS=site INSTALLSCRIPT=/usr/local/bin'

That looks suspiciously like two MakeMaker args passed as a single string to list-form of system(@args) rather than being split like a shell command would. There were problems in M::B::Compat about handling MakeMaker arguments at all, so it's possible that that fix exposed a CPANPLUS::Dist::MM bug. -- David

Wed Sep 02 01:29:31 2009 CRAKRJACK [...] cpan.org - Correspondence added

This hackery is what is making this work right now for my (slightly twisted) installation of CPANPLUS ($package is a CPANPLUS::Module object): my $dir = $package->extract(extractdir => $tempdir); # hack around https://rt.cpan.org/Ticket/Display.html?id=32222 if(-e "$dir/Build.PL" && -e "$dir/Makefile.PL") { warn "Makefile.PL and Build.PL both exist - deleting Makefile.PL"; unlink("$dir/Makefile.PL") or die "unlink('$dir/Makefile.PL'): $!"; $package->status->installer_type('CPANPLUS::Dist::Build'); } my $rv = $package->install( target => 'create', prereq_target => 'create', verbose => 1, skiptest => 1, prefix => $prefix, distdir => $repo_root, );

Mon Nov 16 10:52:07 2009 BINGOS [...] cpan.org - Correspondence added 60 min

New versions of CPANPLUS will now set the default configuration of 'prefer_makefile' to be 0 in the following circumstances: if the version of perl is 5.10.1 or greater if both Module::Build and CPANPLUS::Dist::Build are installed and of suitable versions. Many thanks.

Mon Nov 16 10:52:09 2009 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Nov 16 10:52:10 2009 BINGOS [...] cpan.org - Given to BINGOS