Skip Menu |

This queue is for tickets about the FindBin-libs CPAN distribution.

Report information
The Basics
Id: 32160
Status: resolved
Worked: 30 min
Priority: 0/
Queue: FindBin-libs

People
Owner: Nobody in particular
Requestors: mgrimes [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.35
Fixed in: (no value)



Subject: FindBin::libs abspath fails under cygwin
First, nice module! Very handy! Unfortunately, I have run into issues with FindBin::libs when run under cygwin. I believe it is due to abs_path die-ing when a path does not exist. It appears that the issue was partially addressed in the find_libs routine when searching subdir's, but there are two other calls to abs_path that I needed to wrap in an eval in order to get the tests to pass. I have attached a patch that passes tests on both a cygwin and linux box. Thanks again, Mark System details: FindBin-libs-1.35 CYGWIN_NT-5.1 xx 1.5.25(0.156/4/2) 2007-12-14 19:21 i686 Cygwin This is perl, v5.8.8 built for cygwin-thread-multi-64int (with 8 registered patches, see perl -V for more detail)
Subject: FindBin-libs-1.35-cygwin.patch
diff -Naur FindBin-libs-1.35/lib/FindBin/libs.pm FindBin-libs-1.35-cygwin-patch/lib/FindBin/libs.pm --- FindBin-libs-1.35/lib/FindBin/libs.pm 2007-03-30 10:04:26.000000000 -0700 +++ FindBin-libs-1.35-cygwin-patch/lib/FindBin/libs.pm 2008-01-08 10:05:15.000000000 -0800 @@ -174,7 +174,8 @@ # to eval the check for subdir's. my $abs - = abs_path catpath $vol, ( catdir @dirpath, $base ), $empty; + = eval { abs_path catpath $vol, ( catdir @dirpath, $base ), $empty } + || ''; my $sub = $subdir @@ -281,7 +282,7 @@ for( @{ $argz{ ignore } } ) { - if( my $dir = abs_path catdir $_, $base ) + if( my $dir = eval { abs_path catdir $_, $base } ) { if( -d $dir ) {
Subject: Re: [rt.cpan.org #32160] FindBin::libs abspath fails under cygwin
Date: Tue, 08 Jan 2008 14:55:44 -0500
To: bug-FindBin-libs [...] rt.cpan.org
From: Steven Lembark <lembark [...] wrkhors.com>
Show quoted text
> I have attached a patch that passes tests on both a cygwin and linux box.
Thanks, I don't have access to cygwin to test any of this with. I'll eyeball the stuff tonight and try to get a new version out this week. -- Steven Lembark +1 888 359 3508 Workhorse Computing 85-09 90th St lembark@wrkhors.com Woodhaven, NY 11421
Subject: Re: [rt.cpan.org #32160] FindBin::libs abspath fails under cygwin
Date: Sun, 13 Jan 2008 22:41:24 -0500
To: bug-FindBin-libs [...] rt.cpan.org
From: Steven Lembark <lembark [...] wrkhors.com>
Show quoted text
> Unfortunately, I have run into issues with FindBin::libs when run under > cygwin. I believe it is due to abs_path die-ing when a path does not > exist. It appears that the issue was partially addressed in the > find_libs routine when searching subdir's, but there are two other calls > to abs_path that I needed to wrap in an eval in order to get the tests > to pass. > > I have attached a patch that passes tests on both a cygwin and linux box.
Simple enough fix; I've just put 1.36 onto CPAN (if you care, since the version you have locally is fixed in the first place). Thanks for the suggestion. -- Steven Lembark 85-09 90th St. Workhorse Computing Woodhaven, NY, 11421 lembark@wrkhors.com +1 888 359 3508
Subject: Re: [rt.cpan.org #32160] FindBin::libs abspath fails under cygwin
Date: Mon, 14 Jan 2008 18:45:03 -0800
To: bug-FindBin-libs [...] rt.cpan.org
From: "Mark Grimes" <mvgrimes [...] gmail.com>
Show quoted text
> Simple enough fix; I've just put 1.36 onto CPAN > (if you care, since the version you have locally > is fixed in the first place).
Great. I ran the tests under cygwin and it all looks good. Thanks, Mark
Subject: Re: [rt.cpan.org #32160] FindBin::libs abspath fails under cygwin
Date: Tue, 15 Jan 2008 10:16:49 -0500
To: bug-FindBin-libs [...] rt.cpan.org
From: Steven Lembark <lembark [...] wrkhors.com>
Show quoted text
>> Simple enough fix; I've just put 1.36 onto CPAN >> (if you care, since the version you have locally >> is fixed in the first place).
> > Great. I ran the tests under cygwin and it all looks good.
Please warn me if you need any other changes. Nice thing about the module is it's small enough to modify easily :-) -- Steven Lembark +1 888 359 3508 Workhorse Computing 85-09 90th St lembark@wrkhors.com Woodhaven, NY 11421
Seems fixed (no further feedback). Closing bug.