Bug #32157 for Locale-SubCountry: 1.39 doesn't work due to DOS line endings

Tue Jan 08 11:11:51 2008 gregor+debian [...] comodo.priv.at - Ticket created

Subject:	1.39 doesn't work due to DOS line endings
Date:	Tue, 8 Jan 2008 17:11:23 +0100
To:	bug-Locale-SubCountry [...] rt.cpan.org
From:	gregor herrmann <gregor+debian [...] comodo.priv.at>

Hi, yesterday I tried to update the Debian package of Locale::Subcountry to 1.39. The very first test fails, and after digging around for a while I found the reason: the files are changed to DOS line endings (compared to 1.38). The actual problem is in lib/Locale/SubCountry.pm in line 390, where "$current_line eq '<country>'" doesn't match anything from __DATA__ anymore because of the \r\n. I see three options: * convert the file(s) back to UNIX style line endings * change line 390 to something like =~ m/^<country>/ * drop the \r from $current_line before line 390 I guess version 1 is the simplest way to go :) Cheers, gregor, Debian Perl Group -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: Queen: You Take My Breath Away

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Sat Jan 19 20:25:35 2008 kimryan [...] cpan.org - Correspondence added

From:

nospam [...] cpan.org

On Tue Jan 08 11:11:51 2008, gregor+debian@comodo.priv.at wrote: Show quoted text

> Hi, > > yesterday I tried to update the Debian package of Locale::Subcountry > to 1.39. > The very first test fails, and after digging around for a while I > found the reason: the files are changed to DOS line endings (compared > to 1.38). > The actual problem is in lib/Locale/SubCountry.pm in line 390, where > "$current_line eq '<country>'" doesn't match anything from __DATA__ > anymore because of the \r\n. > > I see three options: > * convert the file(s) back to UNIX style line endings > * change line 390 to something like =~ m/^<country>/ > * drop the \r from $current_line before line 390 > > I guess version 1 is the simplest way to go :) > > Cheers, > gregor, Debian Perl Group

In version 1.40, changed all line endinging to Unix style and fixed regexp for <country> to work regardless of line endings.

Sat Jan 19 20:25:45 2008 The RT System itself - Status changed from 'new' to 'open'

Sat Jan 19 20:27:04 2008 kimryan [...] cpan.org - Correspondence added

Fixed in 1.40. Now using UNix line endings and regexp match for <country> works for all types of ling endings.

Sat Jan 19 20:27:12 2008 kimryan [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Jan 19 20:38:06 2008 gregor+debian [...] comodo.priv.at - Correspondence added

Subject:	Re: [rt.cpan.org #32157] 1.39 doesn't work due to DOS line endings
Date:	Sun, 20 Jan 2008 02:37:41 +0100
To:	Kim Ryan via RT <bug-Locale-SubCountry [...] rt.cpan.org>
From:	gregor herrmann <gregor+debian [...] comodo.priv.at>

On Sat, 19 Jan 2008 20:25:45 -0500, Kim Ryan via RT wrote: Show quoted text

> > The very first test fails, and after digging around for a while I > > found the reason: the files are changed to DOS line endings (compared > > to 1.38). > > The actual problem is in lib/Locale/SubCountry.pm in line 390, where > > "$current_line eq '<country>'" doesn't match anything from __DATA__ > > anymore because of the \r\n.

Show quoted text

> In version 1.40, changed all line endinging to Unix style and fixed > regexp for <country> to work regardless of line endings.

Thanks alot for the quick fix! 1.40 is already in Debian unstable. Cheers, gregor -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: Peter Ratzenbeck: Avalon

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Sat Jan 19 20:38:12 2008 The RT System itself - Status changed from 'resolved' to 'open'

Thu Apr 10 19:42:13 2008 kimryan [...] cpan.org - Correspondence added

Fixed line endings in version 1.40

Thu Apr 10 19:42:17 2008 kimryan [...] cpan.org - Status changed from 'open' to 'resolved'