Bug #32105 for Chart-OFC: OFC changed going from V 1.9.5 to 1.9.6

Sat Jan 05 20:17:42 2008 RSAVAGE [...] cpan.org - Ticket created

Subject:

OFC changed going from V 1.9.5 to 1.9.6

I installed OFC V 1.9.6, and to get your great module (for which, $many x $thanx) to work I had to change line 52 of Chart::OFC to be: return $CRLF . join '', map { "$_ \n" } @lines; I found this code in OFC's perl-ofc-library/open_flash_chart.pm.

Sat Jan 19 11:44:49 2008 DROLSKY [...] cpan.org - Correspondence added

On Sat Jan 05 20:17:42 2008, RSAVAGE wrote: Show quoted text

> I installed OFC V 1.9.6, and to get your great module > (for which, $many x $thanx) to work > I had to change line 52 of Chart::OFC to be: > return $CRLF . join '', map { "$_ \n" } @lines; > I found this code in OFC's perl-ofc-library/open_flash_chart.pm.

This is weird. I took a look at the PHP library in the latest version of OFC, and it still uses CRLF as the line separator. AFAIK, the PHP library is the best maintained server-side generator for this library, since it's what the Flash library's author uses. I tested the existing code with OFC 1.9.6 and it seemed to work fine.

Sat Jan 19 11:44:51 2008 The RT System itself - Status changed from 'new' to 'open'

Sat Jan 19 19:02:09 2008 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #32105] OFC changed going from V 1.9.5 to 1.9.6
Date:	Sun, 20 Jan 2008 11:02:32 +1100
To:	bug-Chart-OFC [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

On Sat, 2008-01-19 at 11:44 -0500, DROLSKY via RT wrote: Hi Dave Show quoted text

> I tested the existing code with OFC 1.9.6 and it seemed to work fine.

In that case I guess you should close the ticket. At least there'll be a pointer on RT for anyone else who gets confused. -- Ron Savage ron@savage.net.au http://savage.net.au/index.html

Sat Jan 19 21:35:38 2008 DROLSKY [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jan 20 18:00:32 2008 RSAVAGE [...] cpan.org - Correspondence added

OK. Problem finally understood. I installed Chart::OFC V 0.04, and found I did not have to patch OFC.pm (whew!), as long as I changed my code from: print $chart->as_ofc_data(); to print "\r\n" . $chart->as_ofc_data(); It's the prefix alone which caused the confusion. My suggestion is to add this to OFC.pm so we don't all have to add it on every call to as_ofc_data(). You can see this code in the last line of sub render() in perl-ofc-library/open_flash_chart.pm inside open-flash-chart-1.9.6.zip.

Sun Jan 20 18:00:34 2008 The RT System itself - Status changed from 'resolved' to 'open'

Sun Jan 20 18:21:30 2008 autarch [...] urth.org - Correspondence added

Subject:	Re: [rt.cpan.org #32105] OFC changed going from V 1.9.5 to 1.9.6
Date:	Sun, 20 Jan 2008 17:21:30 -0600 (CST)
To:	RSAVAGE via RT <bug-Chart-OFC [...] rt.cpan.org>
From:	Dave Rolsky <autarch [...] urth.org>

On Sun, 20 Jan 2008, RSAVAGE via RT wrote: Show quoted text

> > Queue: Chart-OFC > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=32105 > > > OK. Problem finally understood. > I installed Chart::OFC V 0.04, and found I did not have to patch OFC.pm > (whew!), as long as I changed my code from: > print $chart->as_ofc_data(); > to > print "\r\n" . $chart->as_ofc_data(); > It's the prefix alone which caused the confusion. My suggestion is to > add this to OFC.pm so we don't all have to add it on every call to > as_ofc_data(). > You can see this code in the last line of sub render() in > perl-ofc-library/open_flash_chart.pm inside open-flash-chart-1.9.6.zip.

That's weird. I'm using this module as-is with 1.9.6 and it works. I wonder if something in my web server stack is somehow adding a newline before the content in a way that satisfies OFC. -dave /*=================================================== VegGuide.Org www.BookIRead.com Your guide to all that's veg. My book blog ===================================================*/

Mon Jan 21 11:54:45 2008 DROLSKY [...] cpan.org - Status changed from 'open' to 'rejected'