Bug #32093 for PathTools: Undefined "mount_flags" sub called in Cygwin.pm.

Sat Jan 05 00:43:42 2008 emazep [...] gmail.com - Ticket created

Subject:

Undefined "mount_flags" sub called in Cygwin.pm.

The subroutine Cygwin::mount_flags called at File/Spec/Cygwin.pm lines 117 and 127 is not defined anywhere. Any File::Spec use (which involves &case_tolerant) under Cygwin thus triggers an "undefined subroutine" error (many tests in t/Spec.t fail as well). Thank you for your invaluable work. Emanuele Zeppieri.

Mon Jan 07 23:03:33 2008 kwilliams [...] cpan.org - Correspondence added

From:

kwilliams [...] cpan.org

Hi Emanuele, Good catch. I think this is only a problem on Cygwin (not other platforms calling functions in Cygwin.pm) and when using a perl older than 5.10. The mount_flags() function was added here: http://public.activestate.com/cgi-bin/perlbrowse/p/31708 Perhaps the right thing to do is to just return 1 if &mount_flags() isn't defined. -Ken

Mon Jan 07 23:03:36 2008 The RT System itself - Status changed from 'new' to 'open'

Mon Jan 07 23:09:11 2008 kwilliams [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Jan 10 02:05:11 2008 emazep [...] gmail.com - Correspondence added

From:

emazep [...] gmail.com

On Mon Jan 07 23:03:33 2008, KWILLIAMS wrote: Show quoted text

> Hi Emanuele, > > Good catch. I think this is only a problem on Cygwin (not other > platforms calling functions in > Cygwin.pm) and when using a perl older than 5.10. The mount_flags() > function was added here: > > http://public.activestate.com/cgi-bin/perlbrowse/p/31708

Hi Ken, yes, I can confirm that I've tested this only on Cygwin's perl 5.8.8 (which is the perl shipped with the current Cygwin distro). (Of course it happens also on Windows when using the Cygwin's perl, since in that case it's $^O eq 'cygwin' anyway.) Show quoted text

> Perhaps the right thing to do is to just return 1 if &mount_flags() > isn't defined.

Yes I think it should be safe (to make the File::Spec::Cygwin::case_tolerant method just return 1 when &mount_flags() isn't defined). Really, as you perfectly know Cygwin permits to create case sensitive Cygwin-only-managed mounts (starting from cygwin 1.5.0), but it's still considered experimental and it certainly falls into a niche use, so I think it's safe to make the extra checks happen only for future Cygwins/perls. (Other than this superficial consideration, I'm by no mean a Cygwin expert.) Thank you! -Emanuele

Thu Jan 10 02:05:13 2008 The RT System itself - Status changed from 'resolved' to 'open'

Tue Jan 15 03:03:24 2008 emazep [...] gmail.com - Correspondence added

From:

emazep [...] gmail.com

I can confirm that PathTools-3.26 solves the problem (tested on Cygwin 1.5.25-7 / perl 5.8.8). Thank you Ken! Cheers, Emanuele.

Tue Jan 15 03:05:01 2008 emazep [...] gmail.com - Status changed from 'open' to 'resolved'

Tue Jan 15 03:05:01 2008 emazep [...] gmail.com - Fixed in 3.26 added