Bug #32069 for Net-CIDR-Compare: DESTROY is not a valid Net::CIDR::Compare macro

Thu Jan 03 16:00:53 2008 cub.uanic [...] gmail.com - Ticket created

Subject:

DESTROY is not a valid Net::CIDR::Compare macro

Great module, thanks! Unfortunately, just before finishing my program get following error: (in cleanup) DESTROY is not a valid Net::CIDR::Compare macro at ./aggregate_nets line 0 Versions that I use: Gentoo Linux 2.6.23-gentoo-r3, profiles/default-linux/x86/2007.0 perl v5.8.8 Net::CIDR v0.11 Net::CIDR::Compare v0.03 Net::Netmask v1.9015 My program is simple networks aggregation (see in attached file).

Subject:

aggregate_nets

Download aggregate_nets
application/octet-stream 403b

Message body not shown because it is not plain text.

Subject:

tst

Download tst
application/octet-stream 201b

Message body not shown because it is not plain text.

Thu Jan 03 16:10:17 2008 cub.uanic [...] gmail.com - Correspondence added

Moreover.... cub@tux ~ % cat q #!/usr/bin/perl -w use Net::CIDR::Compare; my $nets = Net::CIDR::Compare->new(); cub@tux ~ % perl q (in cleanup) DESTROY is not a valid Net::CIDR::Compare macro at q line 0 cub@tux ~ %

Thu Jan 03 16:10:47 2008 cub.uanic [...] gmail.com - Status changed from 'new' to 'open'

Thu Jan 03 16:16:36 2008 cub.uanic [...] gmail.com - Correspondence added

Adding empty destructor solves problem, and all works as expected. cub@tux ~ % diff -u Compare.pm.orig Compare.pm --- Compare.pm.orig 2008-01-03 23:13:25.000000000 +0200 +++ Compare.pm 2008-01-03 23:12:47.000000000 +0200 @@ -305,6 +305,8 @@ return \@result; } +sub DESTROY { +} # Autoload methods go after =cut, and are processed by the autosplit program. cub@tux ~ %

Thu Jan 03 16:42:03 2008 grjones [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #32069] DESTROY is not a valid Net::CIDR::Compare macro
Date:	Thu, 3 Jan 2008 16:41:35 -0500
To:	bug-Net-CIDR-Compare [...] rt.cpan.org
From:	"Gregory Jones" <grjones [...] gmail.com>

I'll add it to the next version. Thanks. On Jan 3, 2008 4:16 PM, Kostyuk Oleg via RT < bug-Net-CIDR-Compare@rt.cpan.org> wrote: Show quoted text

> > Queue: Net-CIDR-Compare > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=32069 > > > Adding empty destructor solves problem, and all works as expected. > > cub@tux ~ % diff -u Compare.pm.orig Compare.pm > --- Compare.pm.orig 2008-01-03 23:13:25.000000000 +0200 > +++ Compare.pm 2008-01-03 23:12:47.000000000 +0200 > @@ -305,6 +305,8 @@ > return \@result; > } > > +sub DESTROY { > +} > > # Autoload methods go after =cut, and are processed by the autosplit > program. > > cub@tux ~ % >

Thu Jan 03 19:59:32 2008 cub.uanic [...] gmail.com - Correspondence added

I want to note that adding empty destructor - it's just dirty hack and not full decision. "DESTROY" should not be considered as "macro" in any way. I have no time to check all internals of your code, but I completely sure that code has some logical error. And I hope that you'll create proper patch instead of my hack. Thanks for your effort.