Skip Menu |

This queue is for tickets about the Class-MethodMaker CPAN distribution.

Report information
The Basics
Id: 31943
Status: rejected
Priority: 0/
Queue: Class-MethodMaker
People
Owner: Nobody in particular
Requestors: bero [...] arklinux.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: 2.08
Fixed in: (no value)

History Show all quoted text
  Thu Dec 27 18:14:14 2007 bero [...] arklinux.org - Ticket created
Subject: Class-MethodMaker 2.08 fails to compile with gcc 4.3
Trying to compile Class-MethodMaker 2.08 with gcc 4.3 and perl 5.10.0 on Linux and FreeBSD results in MethodMaker.xs: In function 'XS_Class__MethodMaker_set_sub_name': MethodMaker.xs:12: error: incompatible types in assignment
  Thu Dec 27 18:21:09 2007 bero [...] arklinux.org - Correspondence added
From: bero [...] arklinux.org
On Thu Dec 27 18:14:14 2007, bero wrote: Show quoted text
> MethodMaker.xs: In function 'XS_Class__MethodMaker_set_sub_name': > MethodMaker.xs:12: error: incompatible types in assignment
Attaching a fix ("works for me" state -- compiles and make test passes, no other tests run)
--- Class-MethodMaker-2.08/MethodMaker.xs.ark 2007-12-27 23:56:54.000000000 +0100 +++ Class-MethodMaker-2.08/MethodMaker.xs 2007-12-28 00:15:13.000000000 +0100 @@ -9,5 +9,4 @@ CODE: CvGV((GV*)SvRV(sub)) = gv_fetchpv(stashname, TRUE, SVt_PV); GvSTASH(CvGV((GV*)SvRV(sub))) = gv_stashpv(pname, 1); - GvNAME(CvGV((GV*)SvRV(sub))) = savepv(subname); - GvNAMELEN(CvGV((GV*)SvRV(sub))) = strlen(subname); + gv_name_set(CvGV((GV*)SvRV(sub)), subname, strlen(subname), 0);
  Sat Dec 29 11:35:51 2007 schwigon [...] webit.de - Correspondence added
Subject: Re: [rt.cpan.org #31943] Class-MethodMaker 2.08 fails to compile with gcc 4.3
Date: Sat, 29 Dec 2007 17:35:34 +0100
To: bug-Class-MethodMaker [...] rt.cpan.org
From: Steffen Schwigon <schwigon [...] webit.de>
"Bernhard Rosenkraenzer via RT" <bug-Class-MethodMaker@rt.cpan.org> writes: Show quoted text
> Queue: Class-MethodMaker > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=31943 > > > On Thu Dec 27 18:14:14 2007, bero wrote:
>> MethodMaker.xs: In function 'XS_Class__MethodMaker_set_sub_name': >> MethodMaker.xs:12: error: incompatible types in assignment
> > Attaching a fix ("works for me" state -- compiles and make test > passes, no other tests run) > --- Class-MethodMaker-2.08/MethodMaker.xs.ark 2007-12-27 23:56:54.000000000 +0100 > +++ Class-MethodMaker-2.08/MethodMaker.xs 2007-12-28 00:15:13.000000000 +0100 > @@ -9,5 +9,4 @@ > CODE: > CvGV((GV*)SvRV(sub)) = gv_fetchpv(stashname, TRUE, SVt_PV); > GvSTASH(CvGV((GV*)SvRV(sub))) = gv_stashpv(pname, 1); > - GvNAME(CvGV((GV*)SvRV(sub))) = savepv(subname); > - GvNAMELEN(CvGV((GV*)SvRV(sub))) = strlen(subname); > + gv_name_set(CvGV((GV*)SvRV(sub)), subname, strlen(subname), 0);
Thanks for your report and patch. Did you already try Class::MethodMaker version 2.10? The versions after 2.08 already contain patches for working with Perl 5.10. Maybe they already do the trick. (Greeti+Tha)nX Steffen -- Steffen Schwigon <schwigon@webit.de> Dresden Perl Mongers <http://dresden-pm.org/> Deutscher Perl-Workshop <http://www.perl-workshop.de/>
  Sat Dec 29 11:35:52 2007 The RT System itself - Status changed from 'new' to 'open'
  Wed Apr 02 14:32:00 2008 schwigon [...] cpan.org - Correspondence added
I close this bug because Perl 5.10 incompatibility issues are fixed in later versions after 2.08. Regards, Steffen -- Steffen Schwigon <schwigon@webit.de> Dresden Perl Mongers <http://dresden-pm.org/> Deutscher Perl-Workshop <http://www.perl-workshop.de/>
  Wed Apr 02 14:33:23 2008 schwigon [...] cpan.org - Status changed from 'open' to 'rejected'