Skip Menu |

This queue is for tickets about the POE-Component-Server-HTTP CPAN distribution.

Report information
The Basics
Id: 31810
Status: open
Priority: 0/
Queue: POE-Component-Server-HTTP

People
Owner: Nobody in particular
Requestors: perl [...] pied.nu
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.09
Fixed in: (no value)



Subject: Many fixes / improvements
This patch : - removes all use of closures. The closers where capturing unnecessary objects and preventing perl's GC; - adds cleanup_connection(), which removes stale request/response objects from a connection object; - adds close_connection() so all that code is in one spot; - adds a hook to discover when a connection is closed; - checks response Connection for close before turning on keep-alive (Above 2 needed by PoCo::Server::HTTP::KeepAlive); - adds doco to ::Connection, ::Request, ::Response; - tweak Server::HTTP doco; - better queue handling for error responses; - make sure PostHandler is only called once per request; - add test for sane shutdown; - added fix_headers(), which puts all that code in one spot; - Headers are added to response only if one isn't already defined; - HEAD requests shouldn't have a content-length. Please include this patch in a CPAN release sooner then later. If you do not want to continue maintaining POE::Component::Server::HTTP, I will be more then happy to do so. -Philip
Subject: PG-PoCo-Server-HTTP-Closures-Errors-on_close-more.0.patch

Message body is not shown because it is too large.

This patch fixes issues that were causing connections to be stuck in a close_wait state. Module hasn't been updated in 2+ years, can we look at having this merged and a new release issues? On Fri Dec 21 12:45:45 2007, GWYN wrote: Show quoted text
> This patch : > - removes all use of closures. The closers where capturing > unnecessary objects and preventing perl's GC; > - adds cleanup_connection(), which removes stale request/response > objects from a connection object; > - adds close_connection() so all that code is in one spot; > - adds a hook to discover when a connection is closed; > - checks response Connection for close before turning on keep-alive > (Above 2 needed by PoCo::Server::HTTP::KeepAlive); > - adds doco to ::Connection, ::Request, ::Response; > - tweak Server::HTTP doco; > - better queue handling for error responses; > - make sure PostHandler is only called once per request; > - add test for sane shutdown; > - added fix_headers(), which puts all that code in one spot; > - Headers are added to response only if one isn't already defined; > - HEAD requests shouldn't have a content-length. > > Please include this patch in a CPAN release sooner then later. If you > do not want to continue maintaining POE::Component::Server::HTTP, I will > be more then happy to do so. > > -Philip