Bug #31498 for Catalyst-Plugin-ConfigLoader: Load config files in alphanumeric order

Thu Dec 13 14:59:23 2007 jonh [...] nmgi.com - Ticket created

Subject:

Load config files in alphanumeric order

This is a simple patch to sort config files alphanumerically before loading them, to allow intentional ordering of config files, such that overrides can be more useful, particularly in a development environment. For example: myapp.conf myapp_10_devel.conf myapp_20_experimental.conf myapp_local.conf

Subject:

CL.patch

--- /usr/share/perl5/Catalyst/Plugin/ConfigLoader.pm 2007-11-21 12:53:05.000000000 -0600 +++ ConfigLoader.pm 2007-12-13 13:23:46.000000000 -0600 @@ -73,7 +73,7 @@ # load all the normal cfgs, then the local cfgs last so they can override # normal cfgs - $c->load_config( $_ ) for @cfg, @localcfg; + $c->load_config( $_ ) for (reverse sort @cfg), (reverse sort @localcfg); $c->finalize_config; $c->NEXT::setup( @_ );

Thu Dec 13 15:30:29 2007 jonh [...] nmgi.com - Correspondence added

From:

jonh [...] nmgi.com

This patch properly sorts the keys of each element of @cfg and @localcfg, rather than sorting the hashrefs themselves.

--- /root/ConfigLoader.pm 2007-12-13 14:17:19.000000000 -0600 +++ ./ConfigLoader.pm 2007-12-13 14:29:24.000000000 -0600 @@ -73,7 +73,8 @@ # load all the normal cfgs, then the local cfgs last so they can override # normal cfgs - $c->load_config( $_ ) for @cfg, @localcfg; + $c->load_config( $_ ) for ( sort { ( keys %$a )[ 0 ] cmp ( keys %$b )[ 0 ] } @cfg ), + ( sort { ( keys %$a )[ 0 ] cmp ( keys %$b )[ 0 ] } @localcfg ); $c->finalize_config; $c->NEXT::setup( @_ );

Mon Dec 17 12:44:53 2007 bricas [...] cpan.org - Taken

Wed Feb 06 11:40:07 2008 bricas [...] cpan.org - Correspondence added

On Thu Dec 13 15:30:29 2007, jonh wrote: Show quoted text

> This patch properly sorts the keys of each element of @cfg and > @localcfg, rather than sorting the hashrefs themselves.

A tentative patch (slightly different than what you've supplied) has been checked into the repository at revision 7437 [1]. Please check it out [2] and test it. -Brian [1] http://dev.catalyst.perl.org/svnweb/Catalyst/revision/?rev=7437 [2] http://dev.catalyst.perl.org/repos/Catalyst/trunk/Catalyst-Plugin-ConfigLoader/

Wed Feb 06 11:40:19 2008 The RT System itself - Status changed from 'new' to 'open'

Fri May 02 10:13:29 2008 bricas [...] cpan.org - Correspondence added

Version 0.20 released to CPAN.

Fri May 02 10:14:48 2008 bricas [...] cpan.org - Status changed from 'open' to 'resolved'