Bug #31403 for Sub-Uplevel: Example missing #!/usr/bin/perl

Wed Dec 12 06:08:31 2007 dam [...] modsoftsys.com - Ticket created

Subject:

Example missing #!/usr/bin/perl

Hi, There's a missing "shebang" at the top of examples/uplevel-demo.pl . As the file is shipped with executable bit set, it seems that the intention is for it to be directly executable, which is not possible without "#!/usr/bin/perl" on the first line. Trivial patch attached. Thanks, dam

Subject:

examples-shebang.patch

Index: libsub-uplevel-perl/examples/uplevel-demo.pl =================================================================== --- libsub-uplevel-perl.orig/examples/uplevel-demo.pl 2007-12-12 13:01:53.000000000 +0200 +++ libsub-uplevel-perl/examples/uplevel-demo.pl 2007-12-12 13:02:02.000000000 +0200 @@ -1,3 +1,4 @@ +#!/usr/bin/perl use strict; use warnings;

Wed Dec 12 08:03:08 2007 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #31403] Example missing #!/usr/bin/perl
Date:	Wed, 12 Dec 2007 08:02:29 -0500
To:	bug-Sub-Uplevel [...] rt.cpan.org
From:	"David Golden" <dagolden [...] cpan.org>

On Dec 12, 2007 6:08 AM, Damyan Ivanov via RT <bug-Sub-Uplevel@rt.cpan.org> wrote: Show quoted text

> As the file is shipped with executable bit set, it seems that the > intention is for it to be directly executable, which is not possible > without "#!/usr/bin/perl" on the first line.

Thank you for noticing that -- that's very subtle. I use several custom compiled versions of perl that don't live in /usr/bin, so I'll either add my usual incantation "#!/usr/bin/env perl" or else just remove the executable bit. David

Wed Dec 12 08:03:10 2007 The RT System itself - Status changed from 'new' to 'open'

Wed Dec 12 08:16:30 2007 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #31403] Example missing #!/usr/bin/perl
Date:	Wed, 12 Dec 2007 05:15:43 -0800
To:	bug-Sub-Uplevel [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] pobox.com>

Damyan Ivanov via RT wrote: Show quoted text

> There's a missing "shebang" at the top of examples/uplevel-demo.pl . > > As the file is shipped with executable bit set, it seems that the > intention is for it to be directly executable, which is not possible > without "#!/usr/bin/perl" on the first line. > > Trivial patch attached.

That's not really viable as it assumes /usr/bin/perl is the location of the perl which installed Sub::Uplevel which is often untrue. There are facilities to write the correct #! line for programs to be installed, but uninstalled examples have to be run through perl. Presumably the person looking inside the source directory at the example code knows how to do this. So the executable bit should just be removed. -- Whip me, beat me, make my code compatible with VMS!

Wed Dec 12 08:33:47 2007 dam [...] modsoftsys.com - Correspondence added

Subject:	Re: [rt.cpan.org #31403] Example missing #!/usr/bin/perl
Date:	Wed, 12 Dec 2007 15:33:26 +0200
To:	DAGOLDEN via RT <bug-Sub-Uplevel [...] rt.cpan.org>
From:	Damyan Ivanov <dam [...] modsoftsys.com>

-=| DAGOLDEN via RT, Wed, Dec 12, 2007 at 08:03:10AM -0500 |=- Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=31403 > > I use several > custom compiled versions of perl that don't live in /usr/bin, so I'll > either add my usual incantation "#!/usr/bin/env perl" or else just > remove the executable bit.

Removing executable bit (and not providing a shebang line) seems fine to me. It is just an example anyway so not so important to be run "easily". -- dam JabberID: dam@jabber.minus273.org

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Wed Dec 12 08:37:34 2007 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #31403] Example missing #!/usr/bin/perl
Date:	Wed, 12 Dec 2007 08:36:59 -0500
To:	bug-Sub-Uplevel [...] rt.cpan.org
From:	"David Golden" <dagolden [...] cpan.org>

On Dec 12, 2007 8:33 AM, Damyan Ivanov via RT <bug-Sub-Uplevel@rt.cpan.org> wrote: Show quoted text

> Removing executable bit (and not providing a shebang line) seems fine to > me. It is just an example anyway so not so important to be run "easily".

It's fixed in the repository. In the next release of Sub::Uplevel (whenever that will be) the executable bit will be cleared. David

Thu Feb 21 15:00:23 2008 dagolden [...] cpan.org - Correspondence added

fixed

Thu Feb 21 15:00:25 2008 dagolden [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #31403 for Sub-Uplevel: Example missing #!/usr/bin/perl

Preferred bug tracker