Bug #31273 for URI: New-style URIs for query parameters

Thu Dec 06 10:59:33 2007 EDAVIS [...] cpan.org - Ticket created

Subject:

New-style URIs for query parameters

Recent versions of the CGI module default to 'new-style URIs' where query parameters are separated with ; instead of &. The URI module should have an option to do the same, even if it is not on by default. Arguably the bug is with CGI, that it should be using URI instead of its own code, but in either case an enhancement to URI is needed. From the perldoc: $uri->query_form( \%hash ) Sets and returns query components that use the applica- tion/x-www-form-urlencoded format. Key/value pairs are separated by "&", and the key is separated from the value by a "=" character. With this proposed feature it would say that key/value pairs are separated by "&", or by ";" if the newstyle_uris option is set.

Wed Jun 11 18:00:15 2008 gnuruandstuff [...] yahoo.co.uk - Correspondence added

From:

gnuruandstuff [...] yahoo.co.uk

On Thu Dec 06 10:59:33 2007, EDAVIS wrote: Show quoted text

> > With this proposed feature it would say that key/value pairs are > separated by "&", or by ";" if the newstyle_uris option is set.

I have no real idea why this issue with URI.pm wasn't fixed years ago, say in 1997. There are a few issues however. Firstly, URI.pm returns a blessed scalar. Note this isn't the sort of blessed scalar that one finds in inside-out objects. It's just a blessed scalar which means that attributes that don't form part of the scalar itself. Therefore an attribute such as your proposed 'newstyle_uris' option aren't possible. To resolve that issue, you'd need either to turn the URI.pm objects into something like hashes or else into inside-out objects. Those solutions do raise other issues, however. My preferred solution would be to have a new method in URI::_query that implements the desired functionality, called, say, "query_form_newstyle". Better still, I'd rename the current query_form, query_form_oldstyle and have the the subroutine named query_form return new style queries. This solution is extremely simple and could be implemented whilst falling over. There might be some duplicate code, but that minor issue could also be resolved during the same fall, whilst bumping one's head at the end of the fall.

Wed Jun 11 18:00:17 2008 The RT System itself - Status changed from 'new' to 'open'

Thu Jun 12 03:34:27 2008 gnuruandstuff [...] yahoo.co.uk - Correspondence added

From:

gnuruandstuff [...] yahoo.co.uk

Patch is attached. Note this patch ensures that all the tests pass. So: perl Makefile.PL make make test will pass. As suggested with this patch "query_form" automatically assumes that the separator is ';'. "query_form_oldstyle" is available for those who want queries generated with '&'. Regards

Download URI-1.36-patch.dif
video/dv 10.1k

Message body not shown because it is not plain text.

Fri Jun 27 06:07:26 2008 GAAS [...] cpan.org - Correspondence added

URI-1.37 comes with this patch to address this issue: http://gitorious.org/projects/perl-uri/repos/mainline/commits/d549f27f719dd489eaf399d40c02269804848449

Fri Jun 27 06:07:29 2008 GAAS [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Jan 04 12:51:31 2013 EDAVIS [...] cpan.org - Correspondence added

(gitorious.org has broken the link, here is another location: http://gitorious.org/~jnapiorkowski/perl-uri/uri-heuristicstest-fix/commit/d549f27f719dd489eaf399d40c02269804848449 )

Fri Jan 04 12:51:32 2013 The RT System itself - Status changed from 'resolved' to 'open'