Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Pod CPAN distribution.

Report information
The Basics
Id: 31135
Status: rejected
Priority: 0/
Queue: Test-Pod

People
Owner: Nobody in particular
Requestors: rmayorga [...] debian.org.sv
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: all_pod_files_ok() doesn't recognize pod files as pod
Date: Sat, 01 Dec 2007 20:17:27 -0600
To: bug-Test-Pod [...] rt.cpan.org
From: Rene Mayorga <rmayorga [...] debian.org.sv>
Hi, Test::Pod::_is_perl check if the file has ^#!.*perl wich is not requiered to be a valid a pod. This Bug was reported at debian with 1.20, I checked 1.26, and is still valid. You can check the bug reported at Debian BTS at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=322412 Cheers -- Rene Mauricio Mayorga | GPG: A209C305 http://rmayorga.org | -------------------------------------------------- 08B6 58AB A691 DD56 C30B 8D37 8040 19FA A209 C305
Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

From: GWOLF [...] cpan.org
Umh... It seems to me that either the bug submitter didn't understand the logic of the _is_perl function or that it changed over the time. The function reads: ------------------------------------------------------------ sub _is_perl { my $file = shift; return 1 if $file =~ /\.PL$/; return 1 if $file =~ /\.p(l|m|od)$/; return 1 if $file =~ /\.t$/; local *FH; open FH, $file or return; my $first = <FH>; close FH; return 1 if defined $first && ($first =~ /^#!.*perl/); return; } ------------------------------------------------------------ This means, the function will return true if: - The file is called *.PL, *.pm, *.pm, *.pod or *.t - The file starts with "#!.*perl" (i.e. #!/usr/bin/perl) So... Well, yes, the module uses some sometimes-incorrect-heuristics, but this bug "per se" does not exist. Still, maybe it'd be good to add an option not to require _is_perl to be run on each file - but this is up to upstream, I guess. I'll send a copy of this idea to the bug on rt.cpan.org, and close the bug in the Debian BTS. Greetings,
This isn't a problem. The check for the shebang line is to find other sources of pod, specifically extensionless shell scripts that are actually Perl.