Skip Menu |

This queue is for tickets about the Test-Class CPAN distribution.

Report information
The Basics
Id: 31122
Status: resolved
Priority: 0/
Queue: Test-Class

People
Owner: Nobody in particular
Requestors: chris+rt [...] chrisdolan.net
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.24
Fixed in: (no value)



Subject: Fail on Strawberry Perl 5.8.8 due to path separator in t/todo.t
In t/todo.t, there's a comment that says: my $SEP = '/'; # use forward slash even on Win32 but that's not true under Strawberry Perl. Instead, I recommend changing test_err( "# Failed (TODO) test (t${SEP}todo.t at line 16)" ); to test_err( "#\s+Failed \(TODO\) test.*?\n?.*?at t[/\\]todo\.t line 16.*\n?" ); (cribbing from Test::Builder::Tester _translate_Failed_check) Alternatively, one would have to get Strawberry Perl to change its line separators in Test::More output, which seems less likely.
On Sat Dec 01 01:29:19 2007, CDOLAN wrote: Show quoted text
> In t/todo.t, there's a comment that says: > my $SEP = '/'; # use forward slash even on Win32 > but that's not true under Strawberry Perl. Instead, I recommend changing > test_err( "# Failed (TODO) test (t${SEP}todo.t at line 16)" ); > to > test_err( "#\s+Failed \(TODO\) test.*?\n?.*?at t[/\\]todo\.t line > 16.*\n?" ); > > (cribbing from Test::Builder::Tester _translate_Failed_check) > > Alternatively, one would have to get Strawberry Perl to change its line > separators in Test::More output, which seems less likely.
Oops, bad syntax. The following actually works: test_err( "/#\\s+Failed \\(TODO\\) test.*?\\n?.*?at t[\\/\\\\]todo\\.t line 16.*\\n?/" );
On Sat Dec 01 01:36:02 2007, CDOLAN wrote: Show quoted text
> On Sat Dec 01 01:29:19 2007, CDOLAN wrote:
> > In t/todo.t, there's a comment that says: > > my $SEP = '/'; # use forward slash even on Win32 > > but that's not true under Strawberry Perl. Instead, I recommend changing > > test_err( "# Failed (TODO) test (t${SEP}todo.t at line 16)" ); > > to > > test_err( "#\s+Failed \(TODO\) test.*?\n?.*?at t[/\\]todo\.t line > > 16.*\n?" ); > > > > (cribbing from Test::Builder::Tester _translate_Failed_check) > > > > Alternatively, one would have to get Strawberry Perl to change its line > > separators in Test::More output, which seems less likely.
> > Oops, bad syntax. The following actually works: > > test_err( "/#\\s+Failed \\(TODO\\) test.*?\\n?.*?at t[\\/\\\\]todo\\.t > line 16.*\\n?/" );
Thanks. Fixed in 0.25 which should be hitting CPAN soon. (although I justed used $0 since, AFAIK, test_err doesn't support regexps??? Cheers, Adrian