Skip Menu |

This queue is for tickets about the Font-AFM CPAN distribution.

Report information
The Basics
Id: 30966
Status: resolved
Priority: 0/
Queue: Font-AFM

People
Owner: Nobody in particular
Requestors: andy [...] hexten.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.19
Fixed in: (no value)



Subject: t/afm.t generating idiosyncratic TAP
Hi Gisle, Andreas Koenig has noticed that t/afm.t emits TAP which isn't quite correctly formed - and which breaks under Test::Harness 3. See https://rt.cpan.org/Ticket/Display.html?id=30962 for more details. I'm attaching a patch that makes the test emit valid TAP. I wonder if you'd consider accepting it? Thanks :)
Subject: 20071125-andya.patch
--- ../Font-AFM-1.19.orig/t/afm.t 1999-02-22 18:52:21.000000000 +0000 +++ t/afm.t 2007-11-25 16:45:41.000000000 +0000 @@ -5,13 +5,12 @@ }; if ($@) { if ($@ =~ /Can't find the AFM file for/) { - print "1..0\n"; - print $@; - print "ok 1\n"; + print "1..0 # Can't find required font\n"; + warn "# $@"; } else { print "1..1\n"; - print $@; - print "not ok 1\n"; + warn "# $@"; + print "not ok 1 Found font OK\n"; } exit; } @@ -20,10 +19,8 @@ $sw = $font->stringwidth("Gisle Aas"); if ($sw == 4279) { - print "Stringwith for Helvetica seems to work\n"; - print "ok 1\n"; + print "ok 1 Stringwith for Helvetica seems to work\n"; } else { - print "not ok 1\n"; - print "The stringwidth of 'Gisle Aas' should be 4279 (is was $sw)\n"; + print "not ok 1 The stringwidth of 'Gisle Aas' should be 4279 (is was $sw)\n"; }
Applied. Thanks!