Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Rubric CPAN distribution.

Report information
The Basics
Id: 30822
Status: resolved
Priority: 0/
Queue: Rubric

People
Owner: Nobody in particular
Requestors: genehack [...] genehack.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: patches for XHTML compliance
Date: Sun, 18 Nov 2007 11:21:11 -0500
To: bug-Rubric <bug-Rubric [...] rt.cpan.org>
From: John SJ Anderson <genehack [...] genehack.org>
The following patch changes several of the templates to make them fully XHTML compliant: diff --git a/share/templates/entries.html b/share/templates/entries.html index 2d834fa..7b22ee1 100644 --- a/share/templates/entries.html +++ b/share/templates/entries.html @@ -48,17 +48,17 @@ </div> [% END %] - <div class='search'> + <form action='[% self_url %]' style='display:inline'> + <div class='search'> <span>search:</span> - <form action='[% self_url %]' style='display:inline'> [% widget.input(name => 'like', attr => { size => 60 }) %] - </form> - </div> + </div> + </form> <h2 class='query'>[% query_description %]</h2> <div class='rss'><a href='[% uri.entries(user => user, tags => tags, has_link => has_link, has_body => has_body, format => "rss" ) %]'>RSS</a> available for this query</div> - <div class='expandcollapse'><a href='?long_form=[% long_form ? 0 : 1 %]&page=[%page%]'>[% + <div class='expandcollapse'><a href='?long_form=[% long_form ? 0 : 1 %]&amp;page=[%page%]'>[% long_form ? "collapse" : "expand" %]</a> entry bodies</div> <div class='entries'> diff --git a/share/templates/login.html b/share/templates/login.html index 93dcaaa..dd7d6a5 100644 --- a/share/templates/login.html +++ b/share/templates/login.html @@ -12,13 +12,13 @@ [% END %] [% END %] <div class='loginform'> - <form id='loginform' action='[% uri.login %]' method='POST'> + <form id='loginform' action='[% uri.login %]' method='post'> <table> <tr> - <th>username</th><td>[% widget.input(name => 'user', value=> user) %] + <th>username</th><td>[% widget.input(name => 'user', value=> user) %]</td> </tr> <tr> - <th>password</th><td>[% widget.password(name => 'password') %] + <th>password</th><td>[% widget.password(name => 'password') %]</td> </tr> <tr><td class='submit' colspan='2'> <input type='submit' name='submit' value='login' /> diff --git a/share/templates/newuser.html b/share/templates/newuser.html index 57f7458..abf0cf2 100644 --- a/share/templates/newuser.html +++ b/share/templates/newuser.html @@ -12,7 +12,7 @@ <h3 class='error'>Your passwords didn't match!</h3> [% END %] <div class='newuser'> - <form id='newuser' action='newuser' method='POST'> + <form id='newuser' action='newuser' method='post'> <table> <tr><th>username</th><td><input name='username' /></tr> <tr> diff --git a/share/templates/post.html b/share/templates/post.html index f65ab8b..494cf48 100644 --- a/share/templates/post.html +++ b/share/templates/post.html @@ -38,7 +38,7 @@ <h2>new entry</h2> [% END %] <div class='entryform'> - <form id='entryform' action="[% xml_escape(uri.post_entry) %]" method='POST'> + <form id='entryform' action="[% xml_escape(uri.post_entry) %]" method='post'> <table> [%# Yup. This is really, really ugly. %] [% FOREACH param = [ "uri", "title", "description", "tags" ] %] diff --git a/share/templates/preferences.html b/share/templates/preferences.html index 8435b20..379200c 100644 --- a/share/templates/preferences.html +++ b/share/templates/preferences.html @@ -15,7 +15,7 @@ <h3 class='error'>Your passwords didn't match!</h3> [% END %] <div class='preferences'> - <form id='preferences' action='preferences' method='POST'> + <form id='preferences' action='preferences' method='post'> <table> <tr> <th>old password</th> john. -- I WILL NOT TORMENT THE EMOTIONALLY FRAIL I WILL NOT TORMENT THE EMOTIONALLY FRAIL I WILL NOT TORMENT THE EMOTIONALLY FRAIL Bart Simpson on chalkboard in episode 8F10
applied, and only six years later! thanks -- rjbs