Skip Menu |

This queue is for tickets about the DBIx-JSON CPAN distribution.

Report information
The Basics
Id: 30809
Status: resolved
Priority: 0/
Queue: DBIx-JSON

People
Owner: yosty [...] cpan.org
Requestors: cdr [...] xteam.co.at
dbennett [...] cpan.org
jpierce [...] netedgesolutions.com
Randall.Petras [...] qvc.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.02
Fixed in: 0.03



Subject: Typo PrintWarm
Line 70 contains PrintWarm instead of PrintWarn
Subject: DBIx-JSON-0.02-PrintWarn.patch
--- JSON.pm.orig 2007-11-17 11:57:25.128875000 -0600 +++ JSON.pm 2007-11-17 11:57:25.128875000 -0600 @@ -67,7 +67,7 @@ eval { $self->{dbh} = DBI->connect( "dbi:$driver:$dsn", $userid, $passwd, - { PrintWarm => 0, PrintError => 1 } ); + { PrintWarn => 0, PrintError => 1 } ); } or $@ && Carp::croak $@; if ( !$self->{dbh} ) {
Subject: Bug report
Date: Thu, 5 Feb 2009 13:41:12 -0500
To: "bug-DBIx-JSON [...] rt.cpan.org" <bug-DBIx-JSON [...] rt.cpan.org>
From: Randall Petras <Randall.Petras [...] qvc.com>
On line 70 of the code, in the _init sub, you use the term "PrintWarm" it should be "PrintWarn". Around here: sub _init { my $self = shift; my $dsn = shift; my $driver = shift; my $userid = shift; my $passwd = shift; eval { $self->{dbh} = DBI->connect( "dbi:$driver:$dsn", $userid, $passwd, { PrintWarm => 0, PrintError => 1 } ); } or $@ && Carp::croak $@; if ( !$self->{dbh} ) { return (); } else { $self->{dbh}->{PrintError} = 0; } 1; } Other than this minor thing the code seems to work great! Thanks. ---------------------------------------------------------------- Randall Petras QVC This message (including any attachments) contains confidential information intended for a specific individual and purpose, and is protected by law. If you are not the intended recipient of this e-mail (even if the e-mail address above is yours), (i) you may not use, copy or retransmit it, (ii) please delete this message and (iii) please notify the sender immediately. Any disclosure, copying, or distribution of this message or the taking of any action based on it, is strictly prohibited.
Subject: JSON.pm line 70 typo "PrintWarm" instead of "PrintWarn"
Date: Mon, 16 Aug 2010 23:14:21 -0500
To: bug-DBIx-JSON [...] rt.cpan.org
From: Jason Pierce <jpierce [...] netedgesolutions.com>
There is a typo in JSON.pm at line 70. This: { PrintWarm => 0, PrintError => 1 } ); Should be: { PrintWarn => 0, PrintError => 1 } ); -- Jason Pierce jpierce@netedgesolutions.com
Subject: wrong DBI parameter: PrintWarm
Date: Fri, 16 Mar 2018 14:02:29 +0100
To: bug-DBIx-JSON [...] rt.cpan.org
From: Christian Drauch <cdr [...] xteam.co.at>
Hi, I found a typo in DBIx/JSON.pm - you set { PrintWarm => 0, .... } in line 70. The correct parameter is bold printed below.      60 sub _init {      61     my $self   = shift;      62     my $dsn    = shift;      63     my $driver = shift;      64     my $userid = shift;      65     my $passwd = shift;      66      67     eval {      68         $self->{dbh} =      69           DBI->connect( "dbi:$driver:$dsn", $userid, $passwd,      70             { *PrintWarn* => 0, PrintError => 1 } );      71       }      72       or $@ && Carp::croak $@;      73     if ( !$self->{dbh} ) {      74         return ();      75     }      76     else {      77         $self->{dbh}->{PrintError} = 0;      78     }      79     1;      80 } Best regards, Chris
I fixed the typo in 0.03. Thank you very much for the bug report.