Bug #30695 for MIME-Types: Problems with tests depending on environment

Tue Nov 13 10:45:04 2007 gregor+debian [...] comodo.priv.at - Ticket created

Subject:	Problems with tests depending on environment
Date:	Tue, 13 Nov 2007 16:43:57 +0100
To:	bug-MIME-Types [...] rt.cpan.org
From:	gregor herrmann <gregor+debian [...] comodo.priv.at>

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Hi, in the Debian Bug Tracking System we have a bug concerning the tests of MIME::Types 1.21: http://bugs.debian.org/448887 Summary: The tests work in a chroot but fail in a "normal" environment. Find attached a quick patch I've prepared for the Debian package; I'm not sure if it fits the original intentions of the tests but it might at least give you a starting point. Cheers, gregor (Debian Perl Group) -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: Cat Stevens: I Wish, I Wish

Message body is not shown because sender requested not to inline it.

Tue Nov 13 13:03:35 2007 gregor+debian [...] comodo.priv.at - Correspondence added

Subject:	Re: [rt.cpan.org #30695] AutoReply: Problems with tests depending on environment
Date:	Tue, 13 Nov 2007 19:02:43 +0100
To:	Bugs in MIME-Types via RT <bug-MIME-Types [...] rt.cpan.org>
From:	gregor herrmann <gregor+debian [...] comodo.priv.at>

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

On Tue, 13 Nov 2007 10:45:08 -0500, Bugs in MIME-Types via RT wrote: Show quoted text

> in the Debian Bug Tracking System we have a bug concerning the tests > of MIME::Types 1.21: > http://bugs.debian.org/448887 > > Summary: > The tests work in a chroot but fail in a "normal" environment.

Actually the test failure is not caused by the module itself but by a patch that was applied to the Debian package in February 2003: * Patch MIME::Types to read /etc/mime.types during module initialisation. The file is processed after the internal entries, so it will take precendence, http://bugs.debian.org/165940 So, there's no need for you to do anything, as we can patch around our own patch -- unless you decide to include this patch too, which might be a good idea. I'm attaching it to this mail. Cheers, gregor -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: Arlo Guthrie: Ukulele lady

Message body is not shown because sender requested not to inline it.

Wed Nov 14 03:01:09 2007 webmaster [...] nlnet.nl - Correspondence added

Subject:	Re: [rt.cpan.org #30695] AutoReply: Problems with tests depending on environment
Date:	Wed, 14 Nov 2007 09:00:47 +0100
To:	"gregor+debian [...] comodo.priv.at via RT" <bug-MIME-Types [...] rt.cpan.org>
From:	NLnet webmaster <webmaster [...] nlnet.nl>

* gregor+debian@comodo.priv.at via RT (bug-MIME-Types@rt.cpan.org) [071113 18:03]: Show quoted text

> Queue: MIME-Types > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=30695 > > > On Tue, 13 Nov 2007 10:45:08 -0500, Bugs in MIME-Types via RT wrote: >

> > in the Debian Bug Tracking System we have a bug concerning the tests > > of MIME::Types 1.21: > > http://bugs.debian.org/448887 > > > > Summary: > > The tests work in a chroot but fail in a "normal" environment.

> > Actually the test failure is not caused by the module itself but by a > patch that was applied to the Debian package in February 2003: > > * Patch MIME::Types to read /etc/mime.types during module > initialisation. The file is processed after the internal > entries, so it will take precendence, > > http://bugs.debian.org/165940 > > So, there's no need for you to do anything, as we can patch around > our own patch -- unless you decide to include this patch too, which > might be a good idea. I'm attaching it to this mail.

I think that it is a VERY BAD THING to change the functionality of a module in this way. The MIME::Types module has about only three methods, and now someone has changed the behavior of those! So, not CPAN's MIME::Types differs from Debian's in more than just bug-fixes. BAD BAD BAD!!! And that without any contact with the original author. The patch is (against GPL regulation) not sent to me either. There is a module on CPAN which does use the /etc/mime.types directory. It is called File::TypeInfo. Let people use that one. So: I strongly urge you to remove this "smart" patch from the release. It is against decent behavior. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net

Wed Nov 14 03:01:12 2007 The RT System itself - Status changed from 'new' to 'open'

Wed Nov 14 10:45:59 2007 gregor+debian [...] comodo.priv.at - Correspondence added

Subject:	Re: [rt.cpan.org #30695] AutoReply: Problems with tests depending on environment
Date:	Wed, 14 Nov 2007 16:44:45 +0100
To:	NLnet webmaster via RT <bug-MIME-Types [...] rt.cpan.org>
From:	gregor herrmann <gregor+debian [...] comodo.priv.at>

On Wed, 14 Nov 2007 03:01:13 -0500, NLnet webmaster via RT wrote: Show quoted text

> > Actually the test failure is not caused by the module itself but by a > > patch that was applied to the Debian package in February 2003: > > > > * Patch MIME::Types to read /etc/mime.types during module > > initialisation. The file is processed after the internal > > entries, so it will take precendence,

Show quoted text

> I think that it is a VERY BAD THING to change the functionality of a > module in this way. The MIME::Types module has about only three methods, > and now someone has changed the behavior of those! So, not CPAN's > MIME::Types differs from Debian's in more than just bug-fixes. BAD BAD > BAD!!!

I completely agree that it's bad practice to change the functionality of a module without discussing this with the upstream author, and that different versions in CPAN and in Debian are not helpful either. That's why I contacted you 5 minutes after we "detected" this old patch in the Debian package (which was not separated as a file of itself but was just applied to Types.pm by a former maintainer). Show quoted text

> There is a module on CPAN which does use the /etc/mime.types > directory. It is called File::TypeInfo. Let people use that one.

Could you imagine to add a short reference to File::TypeInfo in MIME::Type's documentation? Show quoted text

> So: I strongly urge you to remove this "smart" patch from the > release. It is against decent behavior.

Thanks for the advice, we're going to sort this out ASAP. Cheers, gregor -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: Will Oldham: will oldham - Dreaming my Dreams

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Wed Nov 14 11:22:42 2007 MARKOV [...] cpan.org - Correspondence added

Release 1.22 is now reaching CPAN, and does contain the requested reference to File::TypeInfo

Wed Nov 14 11:22:45 2007 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Nov 14 16:27:02 2007 gregor+debian [...] comodo.priv.at - Correspondence added

Subject:	Re: [rt.cpan.org #30695] Problems with tests depending on environment
Date:	Wed, 14 Nov 2007 21:58:10 +0100
To:	Mark Overmeer via RT <bug-MIME-Types [...] rt.cpan.org>
From:	gregor herrmann <gregor+debian [...] comodo.priv.at>

On Wed, 14 Nov 2007 11:22:45 -0500, Mark Overmeer via RT wrote: Show quoted text

> Release 1.22 is now reaching CPAN, and does contain the requested > reference to File::TypeInfo

Great, thanks alot! A new revision of the MIME::Types (1.21) package has just been uploaded to the Debian archive that drops the "magic patch"; so now MIME::Types is "clean" again. Cheers, gregor -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: Paul Mc Cartney: Pretty Little Head

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Wed Nov 14 16:27:05 2007 The RT System itself - Status changed from 'resolved' to 'open'

Wed Nov 14 17:38:28 2007 MARKOV [...] cpan.org - Correspondence added

Thanks for the professional approach

Wed Nov 14 17:38:45 2007 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'