Bug #30687 for Test-Distribution: Test::Distribution 1.29 breaks Lingua::Stem 0.83

Mon Nov 12 22:04:58 2007 ANDK [...] cpan.org - Ticket created

CC:	SNOWHARE [...] cpan.org
Subject:	Test::Distribution 1.29 breaks Lingua::Stem 0.83

Since Test::Distribution 1.29 the tests to Lingua::Stem fail. Downgrading to 1.28 resolves. t/97_distribution......no such test type: sig # Looks like your test died before it could output anything. Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run Thanks,

Tue Nov 13 19:38:43 2007 srshah [...] cpan.org - Taken

Tue Nov 13 19:41:52 2007 srshah [...] cpan.org - Correspondence added

Hello. Please read the documentation and Changes.pod in T::D 1.29. I think you will find that your statement is incorrect. I also suggest you alter your Build.PL to ensure you have a build_requires. If you like Signatures I'll happily add sig back as an optional option if you raise an enhancement ticket. Best Regards, and lovely to see someone using my module! Sagar

Tue Nov 13 19:41:54 2007 The RT System itself - Status changed from 'new' to 'open'

Tue Nov 13 19:41:54 2007 srshah [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Nov 13 23:38:08 2007 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

CC:	ANDK [...] cpan.org, SNOWHARE [...] cpan.org
Subject:	Re: [rt.cpan.org #30687] Test::Distribution 1.29 breaks Lingua::Stem 0.83
Date:	Wed, 14 Nov 2007 05:30:31 +0100
To:	bug-Test-Distribution [...] rt.cpan.org
From:	andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

>>>>> On Tue, 13 Nov 2007 19:41:54 -0500, " via RT" <bug-Test-Distribution@rt.cpan.org> said:

Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=30687 >

Show quoted text

> Hello.

Hello! Show quoted text

> Please read the documentation and Changes.pod in T::D 1.29. I think you > will find that your statement is incorrect.

What exactly is not correct, please? You changed the public interface of your module (without changing the major version number) and thus broke code that relies on it. Show quoted text

> I also suggest you alter your Build.PL to ensure you have a build_requires.

That's not needed because Lingua::Stem skips test 97 if Test::Distribution is not available. IMO this is much better than a build_requires. Show quoted text

> If you like Signatures I'll happily add sig back as an optional option > if you raise an enhancement ticket.

Consider it raised. Show quoted text

> Best Regards, and lovely to see someone using my module!

-- andreas

Tue Nov 13 23:38:10 2007 The RT System itself - Status changed from 'resolved' to 'open'

Tue Nov 13 23:56:23 2007 sagsshah [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #30687] Test::Distribution 1.29 breaks Lingua::Stem 0.83
Date:	Wed, 14 Nov 2007 04:55:58 +0000
To:	bug-Test-Distribution [...] rt.cpan.org
From:	"Sagar R. Shah" <sagsshah [...] gmail.com>

Hello Andreas, On 14/11/2007, (Andreas J. Koenig) via RT <bug-Test-Distribution@rt.cpan.org> wrote: Show quoted text

> > Queue: Test-Distribution > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=30687 > >

> >>>>> On Tue, 13 Nov 2007 19:41:54 -0500, " via RT" <bug-Test-Distribution@rt.cpan.org> said:

>

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=30687 >

>

> > Hello.

> > Hello! >

> > Please read the documentation and Changes.pod in T::D 1.29. I think you > > will find that your statement is incorrect.

> > What exactly is not correct, please? You changed the public interface > of your module (without changing the major version number) and thus > broke code that relies on it.

I'm not trying to be anal here. It's down to the user to read the changes documentation before upgrading. wrt. version numbering, I didn't realise there were any hard rules. If you would like me to delete 1.29 from CPAN and resubmit it as 2.00 then I would be happy to do so. Test::Distribution is just a module, it has no soul, no living presence, it cannot break anything. [Please don't take my comments as an attempt to be rude, I just come from an eastern culture] Show quoted text

> > I also suggest you alter your Build.PL to ensure you have a build_requires.

> > That's not needed because Lingua::Stem skips test 97 if > Test::Distribution is not available. IMO this is much better than a > build_requires.

Yes it is, if you look at the T::D docs I suggest something very similar. The problem with your approach and my approach in the docs is that it isn't possible to require a certain version. So if a user of your module had a very old version of T::D then your tests would also break. Again it would not be Test::Distribution actually doing the breaking. Show quoted text

> > If you like Signatures I'll happily add sig back as an optional option > > if you raise an enhancement ticket.

> > Consider it raised.

Yey :) I love it when people actually act rather than just whinge. I'm trying very hard to become one of those people too! Show quoted text

> > Best Regards, and lovely to see someone using my module!

> > > -- > andreas > >

Wed Nov 14 00:49:32 2007 srshah [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Nov 14 00:49:32 2007 srshah [...] cpan.org - Severity Critical changed to Important