| Date: | Mon, 28 Jul 2003 20:40:12 +1000 |
| To: | bug-test-signature [...] rt.cpan.org |
| Subject: | [schwern@pobox.com: CPAN/t/signature.t noisy] |
| From: | Iain Truskett <spoon [...] cpan.org> |
----- Forwarded message from Michael G Schwern <schwern@pobox.com> -----
From: Michael G Schwern <schwern@pobox.com>
To: perl5-porters@perl.org, andreas.koenig@anima.de
Subject: CPAN/t/signature.t noisy
Date: Mon, 28 Jul 2003 02:14:19 -0700
Got this from bleadperl:
lib/CPAN/t/signature.................# Next time around, consider install Module::Signature,
# so you can verify the integrity of this distribution.
ok
Passing tests should be quiet. If Module::Signature wants advertising, put
it in the skip message so its at least well formatted.
/usr/local/src/perl-current/t $ ./perl harness ../lib/CPAN/t/signature.t
../lib/CPAN/t/signature....ok
1/1 skipped: - Module::Signature not installed
t/TEST doesn't display skip messages.
Also, I've reversed the order of the tests. No point in trying to
do a host lookup if we don't have Module::Signature installed.
--- lib/CPAN/t/signature.t 2003/07/28 09:09:18 1.1
+++ lib/CPAN/t/signature.t 2003/07/28 09:13:04
@@ -3,13 +3,11 @@
use strict;
print "1..1\n";
-if (!eval { require Socket; Socket::inet_aton('pgp.mit.edu') }) {
- print "ok 1 # skip - Cannot connect to the keyserver";
-}
-elsif (!eval { require Module::Signature; 1 }) {
- warn "# Next time around, consider install Module::Signature,\n".
- "# so you can verify the integrity of this distribution.\n";
+if (!eval { require Module::Signature; 1 }) {
print "ok 1 # skip - Module::Signature not installed\n";
+}
+elsif (!eval { require Socket; Socket::inet_aton('pgp.mit.edu') }) {
+ print "ok 1 # skip - Cannot connect to the keyserver";
}
else {
(Module::Signature::verify() == Module::Signature::SIGNATURE_OK())
--
I stare into the Abyss, and it avoids making eye contact.
Show quoted text
----- End forwarded message -----