Skip Menu |

This queue is for tickets about the DBIx-DBSchema CPAN distribution.

Report information
The Basics
Id: 30561
Status: resolved
Priority: 0/
Queue: DBIx-DBSchema

People
Owner: Nobody in particular
Requestors: ishigaki [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.35
Fixed in: (no value)



Subject: Use of uninitialized value in concatenation (.) or string warnings at sql_create_table
As local_options may be blank(undefined), sql_create_table may vomit uuv warnings when it concatenates sql flagments at line 551 (and actually version 0.35 vomits lots of them while testing Jifty). Attached patch would suppress them.
Subject: DBIx-DBSchema-0.35.patch
diff -ur DBIx-DBSchema-0.35/DBSchema/Table.pm DBIx-DBSchema-0.35-patched/DBSchema/Table.pm --- DBIx-DBSchema-0.35/DBSchema/Table.pm 2007-10-27 21:04:55.000000000 +0900 +++ DBIx-DBSchema-0.35-patched/DBSchema/Table.pm 2007-11-08 05:31:25.795250000 +0900 @@ -360,7 +360,7 @@ if ( defined($value) ) { $self->{local_options} = $value; } else { - $self->{local_options}; + defined $self->{local_options} ? $self->{local_options} : ''; } }
From: ivan-pause [...] 420.am
On Wed Nov 07 15:46:31 2007, ISHIGAKI wrote: Show quoted text
> As local_options may be blank(undefined), sql_create_table may vomit > uuv warnings when it concatenates sql flagments at line 551 (and > actually version 0.35 vomits lots of them while testing Jifty). > Attached patch would suppress them.
patch applied to CVS, will be in 0.36. thanks!