Bug #30274 for File-pushd: Docs don't describe what happens on error

Thu Oct 25 18:17:19 2007 krishnoid [...] wapacut.com - Ticket created

Subject:

Docs don't describe what happens on error

Does pushd() return undef (I'd prefer this) or throw an exception on error when trying to chdir to the new directory? Also, does it set $! on error?

Mon Nov 12 20:56:29 2007 krishnoid [...] wapacut.com - Correspondence added

From:

krishnoid [...] wapacut.com

On Thu Oct 25 18:17:19 2007, krishnoid@wapacut.com wrote: Show quoted text

> Does pushd() return undef (I'd prefer this) or throw an exception on > error when trying to chdir to the new directory? Also, does it set

$! on Show quoted text

> error?

It looks like it croaks: sub pushd { ... croak "Can't locate directory $target_dir: $@" if $@; if ($dest ne $orig) { chdir $dest or croak "Can't chdir to $dest\: $!"; } } But it doesn't croak in DESTROY when it can't chdir back to the previous directory: sub DESTROY { ... my $orig = $self->{_original}; chdir $orig if $orig; # should always be so, but just in case... ... } In any case, it would be helpful to describe both of these behaviors in the docs and show an example using eval {} for error-handling.

Fri Nov 16 08:35:27 2007 dagolden [...] cpan.org - Taken

Fri Nov 16 08:35:32 2007 dagolden [...] cpan.org - Status changed from 'new' to 'open'

Fri May 30 23:58:33 2014 dagolden [...] cpan.org - Correspondence added

It's documented as croaking. Croaking in DESTROY would serve no purpose as Perl throws away such errors. Like most modules, since nothing is said about $!, you can't make any assumptions about what it holds. (It's really not reliable except right after a system call anyway.)

Fri May 30 23:58:35 2014 dagolden [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #30274 for File-pushd: Docs don't describe what happens on error

Preferred bug tracker