Skip Menu |

This queue is for tickets about the libnet CPAN distribution.

Report information
The Basics
Id: 30212
Status: resolved
Priority: 0/
Queue: libnet
People
Owner: Nobody in particular
Requestors: DUTCHMAN [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Oct 22 22:53:00 2007 DUTCHMAN [...] cpan.org - Ticket created
Subject: Exchange commands use dashes
When parsing the hello response: if ($ok) { my $h = ${*$me}{'net_smtp_esmtp'} = {}; my $ln; foreach $ln (@msg) { $h->{uc $1} = $2 if $ln =~ /(\w+)\b[= \t]*([^\n]*)/; } } elsif ($me->status == CMD_ERROR) { @msg = $me->message if $ok = $me->_HELO($domain); } The match should not just be on \w, but include dashes as well. A working fix could be to match on: if $ln =~ /([\w-]+)\b[= \t]*([^\n]*)/; instead. This will allow it to pick up oddities such as Exchange's X-EXPS commands. Thank you, PaulW
  Mon Oct 29 20:00:47 2007 gbarr [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #30212] Exchange commands use dashes
Date: Mon, 29 Oct 2007 19:00:01 -0500
To: bug-libnet [...] rt.cpan.org
From: Graham Barr <gbarr [...] pobox.com>
On Oct 22, 2007, at 9:53 PM, via RT wrote: Show quoted text
> > The match should not just be on \w, but include dashes as well. A > working fix could be to match on: > if $ln =~ /([\w-]+)\b[= \t]*([^\n]*)/; > instead. > > This will allow it to pick up oddities such as Exchange's X-EXPS > commands.
Sigh!, why can people not stick to the spec. RFC2821 states that commands are alphabetic The SMTP commands define the mail transfer or the mail system function requested by the user. SMTP commands are character strings terminated by <CRLF>. The commands themselves are alphabetic characters terminated by <SP> if parameters follow and <CRLF> otherwise. Graham.
  Mon Oct 29 20:00:49 2007 The RT System itself - Status changed from 'new' to 'open'
  Mon Oct 29 20:14:12 2007 pwinkeler [...] pbnj-solutions.com - Correspondence added
Subject: RE: [rt.cpan.org #30212] Exchange commands use dashes
Date: Mon, 29 Oct 2007 20:13:39 -0400
To: <bug-libnet [...] rt.cpan.org>
From: "Paul Winkeler" <pwinkeler [...] pbnj-solutions.com>
Don't I know it! Will this be a patch you are willing to incorporate then, or do I need to find another way to address the issue? Show quoted text
-----Original Message----- From: Graham Barr via RT [mailto:bug-libnet@rt.cpan.org] Sent: Monday, October 29, 2007 8:01 PM To: DUTCHMAN@cpan.org Subject: Re: [rt.cpan.org #30212] Exchange commands use dashes <URL: http://rt.cpan.org/Ticket/Display.html?id=30212 > On Oct 22, 2007, at 9:53 PM, via RT wrote:
> > The match should not just be on \w, but include dashes as well. A > working fix could be to match on: > if $ln =~ /([\w-]+)\b[= \t]*([^\n]*)/; > instead. > > This will allow it to pick up oddities such as Exchange's X-EXPS > commands.
Sigh!, why can people not stick to the spec. RFC2821 states that commands are alphabetic The SMTP commands define the mail transfer or the mail system function requested by the user. SMTP commands are character strings terminated by <CRLF>. The commands themselves are alphabetic characters terminated by <SP> if parameters follow and <CRLF> otherwise. Graham.
  Mon Oct 29 21:54:12 2007 gbarr [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #30212] Exchange commands use dashes
Date: Mon, 29 Oct 2007 20:53:47 -0500
To: bug-libnet [...] rt.cpan.org
From: Graham Barr <gbarr [...] pobox.com>
On Oct 29, 2007, at 7:14 PM, pwinkeler@pbnj-solutions.com via RT wrote: Show quoted text
> Don't I know it! Will this be a patch you are willing to > incorporate then, or > do I need to find another way to address the issue?
I will patch it. Graham.
  Mon Oct 29 22:03:02 2007 pwinkeler [...] pbnj-solutions.com - Correspondence added
Subject: RE: [rt.cpan.org #30212] Exchange commands use dashes
Date: Mon, 29 Oct 2007 22:02:35 -0400
To: <bug-libnet [...] rt.cpan.org>
From: "Paul Winkeler" <pwinkeler [...] pbnj-solutions.com>
Thanks Graham - it has been an extremely useful module to me - I appreciate your work on this very much Show quoted text
-----Original Message----- From: Graham Barr via RT [mailto:bug-libnet@rt.cpan.org] Sent: Monday, October 29, 2007 9:54 PM To: DUTCHMAN@cpan.org Subject: Re: [rt.cpan.org #30212] Exchange commands use dashes <URL: http://rt.cpan.org/Ticket/Display.html?id=30212 > On Oct 29, 2007, at 7:14 PM, pwinkeler@pbnj-solutions.com via RT wrote:
> Don't I know it! Will this be a patch you are willing to > incorporate then, or > do I need to find another way to address the issue?
I will patch it. Graham.
  Sat Feb 09 09:31:38 2008 GBARR [...] CPAN.ORG - Correspondence added
This will be in the next release See http://svn.goingon.net/viewvc/libnet/trunk/Net/SMTP.pm?r1=339&r2=341
  Sat Feb 09 09:31:40 2008 GBARR [...] CPAN.ORG - Status changed from 'open' to 'resolved'