Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 30139
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: MichaelRWolf [...] att.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.078
Fixed in: (no value)



Subject: t/20_policies/BuiltinFunctions/RequireGlobFunction failure on FreeBSD/i386
I'd be glad to do some more testing if you'd like. I had a commit bit on the perlcritic code at one time. I'd also be happy to do some digging around and submit a patch for review. Let me know!! Michael Wolf =============================== $ uname -a FreeBSD 24.kobe.highspeedrails.com 6.1-RELEASE-p12 FreeBSD 6.1-RELEASE-p12 #0: Wed Feb 7 09:20:17 PST 2007 hsri@kobe.highspeedrails.com:/usr/obj/usr/src/sys/HSRSMPAE i386 $ date Fri Oct 19 19:51:59 PDT 2007 $ sudo cpan install Perl::Critic ------------------------------------------------------ t/15_statistics...........................ok t/20_policies.............................ok 25/682 t/20_policies.............................NOK 69# Failed test 'BuiltinFunctions::RequireGlobFunction - line 19 - Multiple globs via <...>' # at t/20_policies.t line 95. # got: '2' # expected: '1' # Violation found: Glob written as <...> at line 2, column 11. See page 167 of PBP. # Violation found: Glob written as <...> at line 2, column 19. See page 167 of PBP. t/20_policies.............................ok 676/682# Looks like you failed 1 test of 682. t/20_policies.............................dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 69 Failed 1/682 tests, 99.85% okay t/20_policy_podspelling...................ok [...] Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/20_policies.t 1 256 682 1 0.15% 69 (3 subtests UNEXPECTEDLY SUCCEEDED), 9 tests skipped. Failed 1/33 test scripts, 96.97% okay. 1/3172 subtests failed, 99.97% okay. *** Error code 255 Stop in /root/.cpan/build/Perl-Critic-1.078. /usr/bin/make test -- NOT OK Running make install make test had returned bad status, won't install without force $
Subject: Re: [rt.cpan.org #30139] t/20_policies/BuiltinFunctions/RequireGlobFunction failure on FreeBSD/i386
Date: Fri, 19 Oct 2007 20:08:42 -0700 (PDT)
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeffrey_thalhammer [...] yahoo.com>
You still have a commit bit (login = "mrwolf"). Feel free to poke around. I haven't tried to reproduce this yet. Are you using the new PPI v1.2? -Jeff Show quoted text
----- Original Message ---- From: "MichaelRWolf@att.net via RT" <bug-Perl-Critic@rt.cpan.org> Sent: Friday, October 19, 2007 7:53:47 PM Subject: [rt.cpan.org #30139] t/20_policies/BuiltinFunctions/RequireGlobFunction failure on FreeBSD/i386 Fri Oct 19 22:53:43 2007: Request 30139 was acted upon. Transaction: Ticket created by MichaelRWolf@att.net Queue: Perl-Critic Subject: t/20_policies/BuiltinFunctions/RequireGlobFunction failure on FreeBSD/i386 Broken in: 1.078 Severity: (no value) Owner: Nobody Requestors: MichaelRWolf@att.net Status: new Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=30139 > I'd be glad to do some more testing if you'd like. I had a commit bit on the perlcritic code at one time. I'd also be happy to do some digging around and submit a patch for review. Let me know!! Michael Wolf =============================== $ uname -a FreeBSD 24.kobe.highspeedrails.com 6.1-RELEASE-p12 FreeBSD 6.1-RELEASE-p12 #0: Wed Feb 7 09:20:17 PST 2007 hsri@kobe.highspeedrails.com:/usr/obj/usr/src/sys/HSRSMPAE i386 $ date Fri Oct 19 19:51:59 PDT 2007 $ sudo cpan install Perl::Critic ------------------------------------------------------ t/15_statistics...........................ok t/20_policies.............................ok 25/682 t/20_policies.............................NOK 69# Failed test 'BuiltinFunctions::RequireGlobFunction - line 19 - Multiple globs via <...>' # at t/20_policies.t line 95. # got: '2' # expected: '1' # Violation found: Glob written as <...> at line 2, column 11. See page 167 of PBP. # Violation found: Glob written as <...> at line 2, column 19. See page 167 of PBP. t/20_policies.............................ok 676/682# Looks like you failed 1 test of 682. t/20_policies.............................dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 69 Failed 1/682 tests, 99.85% okay t/20_policy_podspelling...................ok [...] Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/20_policies.t 1 256 682 1 0.15% 69 (3 subtests UNEXPECTEDLY SUCCEEDED), 9 tests skipped. Failed 1/33 test scripts, 96.97% okay. 1/3172 subtests failed, 99.97% okay. *** Error code 255 Stop in /root/.cpan/build/Perl-Critic-1.078. /usr/bin/make test -- NOT OK Running make install make test had returned bad status, won't install without force $
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
From: cpan [...] chrisdolan.net
Hmm, I'd lay money on PPI 1.200 bug fix that breaks our tests. I patched PPI to better handle <> operators and maybe it affected globs too. I only tested the 1.xxx branch, not 1.078... --Chris
Subject: RE: [rt.cpan.org #30139] t/20_policies/BuiltinFunctions/RequireGlobFunction failure on FreeBSD/i386
Date: Sun, 21 Oct 2007 11:53:12 -0700
To: <bug-Perl-Critic [...] rt.cpan.org>
From: "Michael R. Wolf" <MichaelRWolf [...] att.net>
I *am* using PPI v1.2. Michael -- Michael R. Wolf All mammals learn by playing! MichaelRWolf@att.net Show quoted text
> -----Original Message----- > From: Jeffrey Thalhammer via RT [mailto:bug-Perl-Critic@rt.cpan.org] > Sent: Friday, October 19, 2007 8:09 PM > To: MichaelRWolf@att.net > Subject: Re: [rt.cpan.org #30139] > t/20_policies/BuiltinFunctions/RequireGlobFunction failure on FreeBSD/i386 > > > <URL: http://rt.cpan.org/Ticket/Display.html?id0139 > > > You still have a commit bit (login = "mrwolf"). Feel free to poke around. > > I haven't tried to reproduce this yet. Are you using the new PPI v1.2? > > -Jeff > > ----- Original Message ---- > From: "MichaelRWolf@att.net via RT" <bug-Perl-Critic@rt.cpan.org> > Sent: Friday, October 19, 2007 7:53:47 PM > Subject: [rt.cpan.org #30139] > t/20_policies/BuiltinFunctions/RequireGlobFunction failure on FreeBSD/i386 > > > > Fri Oct 19 22:53:43 2007: Request 30139 was acted upon. > Transaction: Ticket created by MichaelRWolf@att.net > Queue: Perl-Critic > Subject: t/20_policies/BuiltinFunctions/RequireGlobFunction > failure on > FreeBSD/i386 > Broken in: 1.078 > Severity: (no value) > Owner: Nobody > Requestors: MichaelRWolf@att.net > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id0139 > > > > I'd be glad to do some more testing if you'd like. I had a commit bit > on the perlcritic code at one time. I'd also be happy to do some > digging around and submit a patch for review. > > Let me know!! > > Michael Wolf > > =============================== > > $ uname -a > FreeBSD 24.kobe.highspeedrails.com 6.1-RELEASE-p12 FreeBSD > 6.1-RELEASE-p12 #0: Wed Feb 7 09:20:17 PST 2007 > hsri@kobe.highspeedrails.com:/usr/obj/usr/src/sys/HSRSMPAE i386 > $ date > Fri Oct 19 19:51:59 PDT 2007 > > $ sudo cpan install Perl::Critic > ------------------------------------------------------ > > t/15_statistics...........................ok > t/20_policies.............................ok 25/682 > t/20_policies.............................NOK 69# Failed test > 'BuiltinFunctions::RequireGlobFunction - line 19 - Multiple globs via > <...>' > # at t/20_policies.t line 95. > # got: '2' > # expected: '1' > # Violation found: Glob written as <...> at line 2, column 11. See page > 167 of PBP. > # Violation found: Glob written as <...> at line 2, column 19. See page > 167 of PBP. > t/20_policies.............................ok 676/682# Looks like you > failed 1 test of 682. > t/20_policies.............................dubious > Test returned status 1 (wstat 256, 0x100) > DIED. FAILED test 69 > Failed 1/682 tests, 99.85% okay > t/20_policy_podspelling...................ok > > [...] > > Failed Test Stat Wstat Total Fail Failed List of Failed > -------------------------------------------------------------------------- > ----- > t/20_policies.t 1 256 682 1 0.15% 69 > (3 subtests UNEXPECTEDLY SUCCEEDED), 9 tests skipped. > Failed 1/33 test scripts, 96.97% okay. 1/3172 subtests failed, 99.97% > okay. > *** Error code 255 > > Stop in /root/.cpan/build/Perl-Critic-1.078. > /usr/bin/make test -- NOT OK > Running make install > make test had returned bad status, won't install without force > > $ > > > > > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com
I don't see any mention of this in the Changes file or the commit log, but it appears that this problem was resolved in P::C versions >= 1.079.