Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 30097
Status: resolved
Priority: 0/
Queue: CGI
People
Owner: MARKSTOS [...] cpan.org
Requestors: saj_btcrd [...] thecommune.net
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)
Attachments
CGI.pm-30097-patch
CGI.pm-30097-test

History Show all quoted text
  Thu Oct 18 12:31:24 2007 saj_btcrd [...] thecommune.net - Ticket created
Subject: optgroup for scrolling_list
Using optgroups in the values of scrolling_list doesn't work the way it does with popup_menu even though the HTML tags are the same for both.
  Fri Jul 24 21:23:37 2009 MARKSTOS [...] cpan.org - Taken
  Fri Jul 24 21:24:51 2009 MARKSTOS [...] cpan.org - Correspondence added
Subject: Needs Test: optgroup for scrolling_list
On Thu Oct 18 12:31:24 2007, stu42j wrote: Show quoted text
> Using optgroups in the values of scrolling_list doesn't work the way it > does with popup_menu even though the HTML tags are the same for both.
To proceed with possibility changing this, we'll first need an automated test which illustrates the current defect. Mark
  Fri Jul 24 21:24:51 2009 The RT System itself - Status changed from 'new' to 'open'
  Sat Jul 25 17:57:17 2009 http://saj.thecommune.net/ - Correspondence added
From: Stuart Johnston
Here is a patch adding three tests to form.t - One for optgroup itself, and one each for optgroup used with popup_menu and scrolling_list. The first two pass with 3.43. The final test is for this bug. There is also a source patch with a simple copy-paste implementation of the fix. I believe that there are only two differences between popup_menu and scrolling_list (size and multiple) so it might be better to refactor the common code into a single function.
Download CGI.pm-30097-test
application/octet-stream 2.4k

Message body not shown because it is not plain text.

Download CGI.pm-30097-patch
application/octet-stream 1.5k

Message body not shown because it is not plain text.

  Sat Jul 25 18:02:16 2009 MARKSTOS [...] cpan.org - Subject changed from 'optgroup for scrolling_list' to 'PATCH: optgroup for scrolling_list'
  Sat Jul 25 18:04:04 2009 MARKSTOS [...] cpan.org - Correspondence added
On Sat Jul 25 17:57:17 2009, http://saj.thecommune.net/ wrote: Show quoted text
> Here is a patch adding three tests to form.t - One for optgroup itself, > and one each for optgroup used with popup_menu and scrolling_list. The > first two pass with 3.43. The final test is for this bug. > > There is also a source patch with a simple copy-paste implementation of > the fix. I believe that there are only two differences between > popup_menu and scrolling_list (size and multiple) so it might be better > to refactor the common code into a single function.
Great! Thanks for the help. Mark
  Thu Aug 13 21:05:52 2009 MARKSTOS [...] cpan.org - Correspondence added
Thanks, this patch has been applied in my git repo now.
  Thu Aug 13 21:05:55 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'patched'
  Fri Aug 14 21:41:29 2009 MARKSTOS [...] cpan.org - Correspondence added
Subject: released, thanks.
I believe this change was released today as part of CGI.pm 3.45. Thanks for the contribution.
  Fri Aug 14 21:41:29 2009 The RT System itself - Status changed from 'patched' to 'open'
  Fri Aug 14 21:41:30 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri May 23 14:28:47 2014 The RT System itself - Queue changed from CGI.pm to CGI