Skip Menu |

This queue is for tickets about the SVN-Pusher CPAN distribution.

Report information
The Basics
Id: 29916
Status: resolved
Priority: 0/
Queue: SVN-Pusher
People
Owner: SHLOMIF [...] cpan.org
Requestors: dexter [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.04
Fixed in: (no value)

History Show all quoted text
  Thu Oct 11 06:05:15 2007 piotr.roszatycki [...] gmail.com - Ticket created
Subject: [PATCH] Verbatim option is broken for svn:// repos
The new feature provokes coredump without attached patch. It is broken only for svn:// and svn+ssh:// repos. Example output: Source: file:///home/dexter/svk/dexter-cpan Revision: 383 Root: file:///home/dexter/svk/dexter-cpan Path: / Target: svn+ssh://dexter@svn/home/dexter/svn/dexter-cpan Revision: 0 Root: svn+ssh://dexter@svn/home/dexter/svn/dexter-cpan Path: / Retrieving log information from 0 to 383 perl: /build/buildd/subversion-1.4.3dfsg1/subversion/libsvn_ra_svn/marshal.c:444: vwrite_tuple: Assertion `opt || cstr' failed. Aborted (core dumped)
Subject: fix_verbatim_for_svn_ra.diff
Index: lib/SVN/Pusher.pm =================================================================== --- lib/SVN/Pusher.pm (revision 2392) +++ lib/SVN/Pusher.pm (working copy) @@ -233,7 +233,7 @@ my $editor = SVN::Pusher::MirrorEditor->new ($tra->get_commit_editor( $self->{verbatim} - ? $msg + ? "$msg" : ( ($msg?"$msg\n":'') . ":$rev:$self->{source_uuid}:$date:" ) , sub { $self->committed($date, $rev, @_) },
  Thu Oct 11 06:56:31 2007 piotr.roszatycki [...] gmail.com - Correspondence added
I'm attaching the patch with fixed "undefined value" warnings.
Index: lib/SVN/Pusher.pm =================================================================== --- lib/SVN/Pusher.pm (revision 2392) +++ lib/SVN/Pusher.pm (working copy) @@ -233,8 +240,8 @@ my $editor = SVN::Pusher::MirrorEditor->new ($tra->get_commit_editor( $self->{verbatim} - ? "$msg" - : ( ($msg?"$msg\n":'') . ":$rev:$self->{source_uuid}:$date:" ) + ? (defined $msg ? "$msg" : '') + : ( (defined $msg ? "$msg\n" : '') . ":$rev:$self->{source_uuid}:$date:" ) , sub { $self->committed($date, $rev, @_) }, undef, 0));
  Thu Oct 11 06:56:42 2007 The RT System itself - Status changed from 'new' to 'open'
  Fri Oct 12 09:35:03 2007 SHLOMIF [...] cpan.org - Correspondence added
Fixed along with #29838 - closing. Thanks for the patch! Regards, Shlomi Fish
  Fri Oct 12 09:35:06 2007 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri Oct 12 09:35:08 2007 SHLOMIF [...] cpan.org - Given to SHLOMIF