Bug #29864 for MIME-tools: 5.423 omits newlines in the bodies

Tue Oct 09 06:59:07 2007 lace [...] jankratochvil.net - Ticket created

Subject:	5.423 omits newlines in the bodies
Date:	Tue, 9 Oct 2007 12:58:01 +0200
To:	bug-MIME-tools [...] rt.cpan.org
From:	Jan Kratochvil <lace [...] jankratochvil.net>

Hi, after installing 5.423 the attached testcase will produce the mail body: This is a multi-part message in MIME format...------------=_1191926713-21151-0Content-Type: text/plainContent-Disposition: inlineContent-Transfer-Encoding: binaryplain------------=_1191926713-21151-0-- ------------=_1191926713-21151-0-- (yes, the newlines are missing there). Attaching a testcase which produced the two attached mails. It was tested on current Fedora Rawhide (almost Fedora 8) system. Please note that the `$top->print();' command there prints it correctly including the newlines in both cases. Comparing these two versions: MIME-tools-5.420.tar.gz (works) MIME-tools-5.423.tar.gz (broken) Thanks for the otherwise great package, Jan

Download received-broken.gz
application/x-gzip 547b

Message body not shown because it is not plain text.

Download received-ok.gz
application/x-gzip 543b

Message body not shown because it is not plain text.

Message body is not shown because sender requested not to inline it.

Tue Oct 09 09:20:15 2007 dfs [...] roaringpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #29864] 5.423 omits newlines in the bodies
Date:	Tue, 09 Oct 2007 09:19:02 -0400
To:	bug-MIME-tools [...] rt.cpan.org
From:	"David F. Skoll" <dfs [...] roaringpenguin.com>

Hi, Jan, Thanks for the bug report. I created a unit test that illustrates the failure, and will work on fixing it. Regards, David.

Tue Oct 09 09:20:18 2007 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 09 09:28:13 2007 lace [...] jankratochvil.net - Correspondence added

Subject:	Re: [rt.cpan.org #29864] 5.423 omits newlines in the bodies
Date:	Tue, 9 Oct 2007 15:27:50 +0200
To:	"David F. Skoll via RT" <bug-MIME-tools [...] rt.cpan.org>
From:	Jan Kratochvil <lace [...] jankratochvil.net>

On Tue, 09 Oct 2007 15:20:20 +0200, David F. Skoll via RT wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=29864 > > > Hi, Jan, > > Thanks for the bug report. I created a unit test that illustrates the failure, > and will work on fixing it.

Thanks, great you refactored it into a proper unit test. Looking forward, Jan

Tue Oct 09 09:31:47 2007 dfs [...] roaringpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #29864] 5.423 omits newlines in the bodies
Date:	Tue, 09 Oct 2007 09:31:18 -0400
To:	bug-MIME-tools [...] rt.cpan.org
From:	"David F. Skoll" <dfs [...] roaringpenguin.com>

Show quoted text

> Thanks, great you refactored it into a proper unit test.

OK, and now we have a fix that seems to work and not break any of the other tests. Please give this patch a try and let me know how it goes. Regards, David. @@ -765,6 +765,9 @@ sub body { $self->print_body($fh); close($fh); my @ary = split(/\n/, $output); + # Each line needs the terminating newline + @ary = map { "$_\n" } @ary; + return \@ary; } }

Tue Oct 09 09:39:38 2007 lace [...] jankratochvil.net - Correspondence added

CC:	Lukas Horalek <klokan [...] vellum.cz>
Subject:	Re: [rt.cpan.org #29864] 5.423 omits newlines in the bodies
Date:	Tue, 9 Oct 2007 15:39:05 +0200
To:	"David F. Skoll via RT" <bug-MIME-tools [...] rt.cpan.org>
From:	Jan Kratochvil <lace [...] jankratochvil.net>

On Tue, 09 Oct 2007 15:31:49 +0200, David F. Skoll via RT wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=29864 >

... Show quoted text

> OK, and now we have a fix that seems to work and not break any > of the other tests. Please give this patch a try and let me know > how it goes.

Confirming it works flawlessly now (the same mail output as in 5.420) with the full local package, attaching the kangaroomail output, Ccing Kangaroo. Thanks, Jan Show quoted text

> @@ -765,6 +765,9 @@ sub body { > $self->print_body($fh); > close($fh); > my @ary = split(/\n/, $output); > + # Each line needs the terminating newline > + @ary = map { "$_\n" } @ary; > + > return \@ary; > } > }

Subject:	zpráva
Date:	Tue, 9 Oct 2007 15:34:38 +0200
To:	lace2 [...] jankratochvil.net
From:	lace [...] jankratochvil.net

plain

Subject:	zpráva
Date:	Tue, 9 Oct 2007 15:35:00 +0200
To:	lace2 [...] jankratochvil.net
From:	lace [...] jankratochvil.net

plain

Sat Nov 17 11:03:35 2007 dmo+pause [...] dmo.ca - Fixed in 5.424 added

Sat Nov 17 11:03:36 2007 dmo+pause [...] dmo.ca - Status changed from 'open' to 'resolved'