| Subject: | Request for enhancement |
| Date: | Sat, 06 Oct 2007 20:47:05 +0200 |
| To: | bug-Net-xFTP [...] rt.cpan.org |
| From: | Jörg Prante <joergprante [...] netcologne.de> |
Hi Jim,
first of all, I would like to thank you for your wonderful Net::xFTP
perl module. It has helped me much, I use Net::xFTP with great success,
with FTP und SFTP.
When I traverse directories with Net::xFTP, I get the whole list of
entries with 'dir', and simply call 'dir' recursively on each entry
without checking for directory type, because 'isadir' is too expensive
(pwd, cwd). If the path given to 'dir' is not a directory, a warning is
issued:
Use of uninitialized value in pattern match (m//)
at .../lib/perl5/site_perl/5.8.8/Net/xFTP.pm line 454
It would be helpful for avoiding this warning if you can apply a litte
enhancement in Net::xFTP at line 454:
Old:
@dirlist = $self->{xftp}->dir($path||'.');
shift (@dirlist) if ($dirlist[0] =~ /^total \d/);
New:
@dirlist = $self->{xftp}->dir($path||'.');
shift (@dirlist) if ($dirlist[0] and $dirlist[0] =~ /^total \d/);
because there is no guarantee that $ftp->dir always returns a defined
@dirlist on a given path with at least one element.
Possibly it's the same to 'ls' in line 358.
Thank you und best regards,
Jörg