Bug #29759 for Gtk2: failing during target podindex

Thu Oct 04 00:22:20 2007 ANDK [...] cpan.org - Ticket created

Subject:

failing during target podindex

make /home/src/perl/repoperls/installed-perls/perl/pEhGb34/perl-5.8.0@32001/bin/perl -I blib/lib -I blib/arch -MGlib::GenPod -MGtk2 \ -e 'add_types ("doctypes", "/home/src/perl/repoperls/installed-perls/perl/pEhGb34/perl-5.8.0@32001/lib/site_perl/5.10.0/i686-linux-64int/Glib/Install/doctypes", "/home/src/perl/repoperls/installed-perls/perl/pEhGb34/perl-5.8.0@32001/lib/site_perl/5.10.0/i686-linux-64int/Cairo/Install/doctypes"); $Glib::GenPod::COPYRIGHT="Copyright (C) 2003-2007 by the gtk2-perl team.\n\nThis software is licensed under the LGPL. See L<Gtk2> for a full notice.\n"; $Glib::GenPod::MAIN_MOD="Gtk2"; xsdoc2pod("build/doc.pl", "blib/lib", "build/podindex");' loaded 10 extra types from doctypes can't open types file /home/src/perl/repoperls/installed-perls/perl/pEhGb34/perl-5.8.0/lib/site_perl/5.10.0/i686-linux-64int/Glib/Install/doctypes: No such file or directory make: *** [build/podindex] Error 2 Somebody in the mangled the path to the doctypes. The correct path would have been /home/src/perl/repoperls/installed-perls/perl/pEhGb34/perl-5.8.0@32001/lib/site_perl/5.10.0/i686-linux-64int/Glib/Install/doctype (note the "@32001" in the path) HTH,

Sat Oct 06 18:29:19 2007 kaffeetisch [...] gmx.de - Correspondence added

RT-Send-CC:

scott [...] asofyet.org

On Thu Oct 04 00:22:20 2007, ANDK wrote: Show quoted text

> Somebody in the mangled the path to the doctypes. The correct path > would > have been > > /home/src/perl/repoperls/installed-perls/perl/pEhGb34/perl- > 5.8.0@32001/lib/site_perl/5.10.0/i686-linux-64int/Glib/Install/doctype > > (note the "@32001" in the path)

Yep, we interpolate the paths unintentionally, it seems. Does the attached patch against Glib fix the problem?

Index: MakeHelper.pm =================================================================== RCS file: /cvsroot/gtk2-perl/gtk2-perl-xs/Glib/MakeHelper.pm,v retrieving revision 1.38 diff -u -d -p -r1.38 MakeHelper.pm --- MakeHelper.pm 24 Sep 2007 17:27:00 -0000 1.38 +++ MakeHelper.pm 6 Oct 2007 22:27:07 -0000 @@ -354,7 +375,7 @@ sub postamble_docs_full { #warn "".scalar(@doctypes)." doctype files\n"; #warn "".scalar(@xs_files)." xs files\n"; - $add_types = "add_types (".join(", ",map {"\"$_\""} @doctypes)."); " + $add_types = "add_types (".join(", ",map {'"'.$_.'"'} @doctypes)."); " if @doctypes; my $docgen_code = ''

Sat Oct 06 18:29:22 2007 The RT System itself - Status changed from 'new' to 'open'

Sun Oct 07 16:21:53 2007 ANDK [...] cpan.org - Correspondence added

No, but $add_types = "add_types (".join(", ",map {'"'.quotemeta($_).'"'} @doctypes)."); " should do the trick. I've tested this and the Makefile now contains: -e 'add_types ("doctypes", "\/home\/sand\/\.cpan\/build\/Glib\-1\.160\-HTLPcQ\/blib\/arch\/Glib\/Install\/doctypes", "\/home\/src\/perl\/repoperls\/installed\-perls\/perl\/pc306NA\/perl\-5\.8\.0\@32029\/lib\/site_perl\/5\.10\.0\/i686\-linux\-64int\/Cairo\/Install\/doctypes"); $$Glib::GenPod::COPYRIGHT="Copyright (C) 2003-2007 by the gtk2-perl team.\n\nThis software is licensed under the LGPL. See L<Gtk2> for a full notice.\n"; $$Glib::GenPod::MAIN_MOD="Gtk2"; $(POD_SET) xsdoc2pod("build/doc.pl", "$(INST_LIB)", "build/podindex");' Looks correct to me. Thanks,

Thu Oct 18 12:09:49 2007 kaffeetisch [...] gmx.de - Correspondence added

On Sun Oct 07 16:21:53 2007, ANDK wrote: Show quoted text

> No, but > > $add_types = "add_types (".join(", ",map {'"'.quotemeta($_).'"'} > @doctypes)."); " > > should do the trick.

Works for me. Committed to both branches. Thanks!

Thu Oct 18 12:09:51 2007 kaffeetisch [...] gmx.de - Status changed from 'open' to 'resolved'