Skip Menu |

This queue is for tickets about the File-Copy-Recursive CPAN distribution.

Report information
The Basics
Id: 29750
Status: resolved
Priority: 0/
Queue: File-Copy-Recursive

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.35
Fixed in: 0.38



Subject: [PATCH] to make module running under 5.005_05
The attached patch just changes a few spots with "mkdir $something" to "mkdir $something, 0777" which is necessary by older perls. It should not change anything for newer perls as 0777 is the default mask. Regards, Slaven
Subject: File-Copy-Recursive-5.5.5.patch
# # # To apply this patch: # STEP 1: Chdir to the source directory. # STEP 2: Run the 'applypatch' program with this patch file as input. # # If you do not have 'applypatch', it is part of the 'makepatch' package # that you can fetch from the Comprehensive Perl Archive Network: # http://www.perl.com/CPAN/authors/Johan_Vromans/makepatch-x.y.tar.gz # In the above URL, 'x' should be 2 or higher. # # To apply this patch without the use of 'applypatch': # STEP 1: Chdir to the source directory. # STEP 2: Run the 'patch' program with this file as input. # #### End of Preamble #### #### Patch data follows #### diff -up '../build/File-Copy-Recursive-0.35-x6E8FI/Recursive.pm' 'File-Copy-Recursive/Recursive.pm' Index: ./Recursive.pm --- ./Recursive.pm Mon Aug 27 23:19:23 2007 +++ ./Recursive.pm Wed Oct 3 23:14:21 2007 @@ -191,7 +191,7 @@ sub dircopy { my ($str,$end,$buf) = @_; $filen++ if $end eq $baseend; $dirn++ if $end eq $baseend; - mkdir $end or return if !-d $end; + mkdir $end, 0777 or return if !-d $end; chmod scalar((stat($str))[2]), $end if $KeepMode; if($MaxDepth && $MaxDepth =~ m/^\d+$/ && $level >= $MaxDepth) { return ($filen,$dirn,$level) if wantarray; @@ -262,8 +262,8 @@ sub pathmk { $zer = 1; } for($zer..$#parts) { - mkdir $pth or return if !-d $pth && !$nofatal; - mkdir $pth if !-d $pth && $nofatal; + mkdir $pth, 0777 or return if !-d $pth && !$nofatal; + mkdir $pth, 0777 if !-d $pth && $nofatal; $pth = File::Spec->catdir($pth, $parts[$_ + 1]) unless $_ == $#parts; } 1; #### End of Patch data #### #### ApplyPatch data follows #### # Data version : 1.0 # Date generated : Wed Oct 3 23:15:05 2007 # Generated by : makepatch 2.03 # Recurse directories : Yes # Excluded files : (\A|/).*\~\Z # (\A|/).*\.a\Z # (\A|/).*\.bak\Z # (\A|/).*\.BAK\Z # (\A|/).*\.elc\Z # (\A|/).*\.exe\Z # (\A|/).*\.gz\Z # (\A|/).*\.ln\Z # (\A|/).*\.o\Z # (\A|/).*\.obj\Z # (\A|/).*\.olb\Z # (\A|/).*\.old\Z # (\A|/).*\.orig\Z # (\A|/).*\.rej\Z # (\A|/).*\.so\Z # (\A|/).*\.Z\Z # (\A|/)\.del\-.*\Z # (\A|/)\.make\.state\Z # (\A|/)\.nse_depinfo\Z # (\A|/)core\Z # (\A|/)tags\Z # (\A|/)TAGS\Z # p 'Recursive.pm' 20364 1191446061 0100644 #### End of ApplyPatch data #### #### End of Patch kit [created: Wed Oct 3 23:15:05 2007] #### #### Patch checksum: 58 2248 9312 #### #### Checksum: 76 2871 60791 ####
Subject: Re: [rt.cpan.org #29750] [PATCH] to make module running under 5.005_05
Date: Wed, 3 Oct 2007 20:45:09 -0500
To: bug-File-Copy-Recursive [...] rt.cpan.org
From: Daniel Muey <webmaster [...] simplemood.com>
thanks, will take a good look ASAP On Oct 3, 2007, at 4:16 PM, Slaven_Rezic via RT wrote: Show quoted text
> > Wed Oct 03 17:16:49 2007: Request 29750 was acted upon. > Transaction: Ticket created by SREZIC > Queue: File-Copy-Recursive > Subject: [PATCH] to make module running under 5.005_05 > Broken in: 0.35 > Severity: Normal > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=29750 > > > > The attached patch just changes a few spots with "mkdir $something" to > "mkdir $something, 0777" which is necessary by older perls. It should > not change anything for newer perls as 0777 is the default mask. > > Regards, > Slaven > > <File-Copy-Recursive-5.5.5.patch>
On Wed Oct 03 21:45:43 2007, webmaster@simplemood.com wrote: Show quoted text
> thanks, will take a good look ASAP
Thank you very much. This is a blocker for getting CPAN::Reporter installing without test failures on 5.005_05. (And _04, too). In my tests, I noted that mkdir( 'foo', umask*() ) also works to just use the current umask setting. Thanks for such a great module!
From: dmuey [...] cpan.org
Show quoted text
> I noted that mkdir( 'foo', umask*() ) also works
not if umask was set: hal9000:~ dmuey$ perl -Mstrict -wle 'umask(0027);mkdir $ARGV[0], 0777;' test_a hal9000:~ dmuey$ perl -Mstrict -wle 'umask(0027);mkdir $ARGV[0], umask();' test_b hal9000:~ dmuey$ ls -ld test_a test_b drwxr-x--- 2 dmuey staff 68 Apr 16 16:52 test_a d--------- 2 dmuey staff 68 Apr 16 16:53 test_b hal9000:~ dmuey$ I'll have it addressed in the next release 0.37 thanks!