Skip Menu |

This queue is for tickets about the HTML-TagCloud CPAN distribution.

Report information
The Basics
Id: 29739
Status: new
Priority: 0/
Queue: HTML-TagCloud

People
Owner: Nobody in particular
Requestors: moldovenu [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: fixes in CSS
Date: Wed, 3 Oct 2007 18:57:05 +0200
To: bug-HTML-TagCloud [...] rt.cpan.org
From: "Adam Bartosik" <moldovenu [...] gmail.com>
Current tag-cloud CSS can be overloaded if you have defined global style for all A elems. I propose to join span-level + span-level A styles to one (there are no visible text outside links, so we don't need it - ?) to avoid such problems, eg: --- /usr/local/share/perl/5.8.8/HTML/TagCloud.pm.foo 2006-11-07 22:05:17.000000000 +0100 +++ TagCloud.pm 2007-10-03 18:48:29.000000000 +0200 @@ -31,8 +31,7 @@ ); foreach my $level (0 .. $self->{levels}) { my $font = 12 + $level; - $css .= "span.tagcloud$level { font-size: ${font}px;}\n"; - $css .= "span.tagcloud$level a {text-decoration: none;}\n"; + $css .= "span.tagcloud$level a { font-size: ${font}px; text-decoration: none;}\n"; } return $css; } Anyway, really simpe & easy to use tag clouder. Good work :) -- Adam Bartosik