| Subject: | Fix for clean -dump output |
When cpantest is used with the -dump switch, at the end of the output
appears the stringified STDOUT filehandle.
As Test::Reporter::write() takes the filehandle to STDOUT there's
no need to print the return value from write(). Made me wonder a
few times already because i want to collect reports from various machines
and send them out later from a central machine with smtp connectivity.
Further i've added a linebreak to the end of the -dump output which makes
it even nicer IMHO.
A diff between the current releases -dump output and with my changes:
--- /tmp/dump.a Mon Oct 1 11:27:08 2007
+++ /tmp/dump.b Mon Oct 1 11:27:11 2007
@@ -38,4 +38,4 @@
gnulibc_version=''
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef,
ccdlflags='-Wl,-R/usr/libdata/perl5/i386-openbsd/5.8.8/CORE'
- cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC 'GLOB(0x8afc4f24)
\ No newline at end of file
+ cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC '
Patch against git attached,
regards
Simon
| Subject: | cpantest.diff |
diff --git a/bin/cpantest b/bin/cpantest
index 28131eb..249eeac 100644
--- a/bin/cpantest
+++ b/bin/cpantest
@@ -47,7 +47,8 @@ $Reporter = Test::Reporter->new();
if ($Dump) {
my $fh; open($fh, '>-') or die "Can't open STDOUT: $!";
- print $Reporter->write($fh);
+ $Reporter->write($fh);
+ print $fh "\n";
} else {
&confirm_send() if not $Automatic;
&send();