Bug #29558 for Net-DNS: Test-Simple-0.73 will break Net-DNS testsuite

Sat Sep 22 22:35:51 2007 ANDK [...] cpan.org - Ticket created

CC:	mschwern [...] cpan.org
Subject:	Test-Simple-0.73 will break Net-DNS testsuite

http://search.cpan.org/src/MSCHWERN/Test-Simple-0.71/Changes there was a bugfix that broke the testsuite for Net-DNS. Test-Simple-0.72 reverted this change because so many modules were affected (DBI, XML-LibXML, File-Slurp, and maybe more). A thread about what exactly happened starts here: http://www.nntp.perl.org/group/perl.qa/2007/09/msg9258.html Please fix your tests so that when 0.73 comes out you will not be affected again. To reproduce the error, install MSCHWERN/Test-Simple-0.71.tar.gz and run the tests on Net::DNS. The result looks like: t/05-rr-rrsort.............You tried to run a test without a plan at t/05-rr-rrsort.t line 7. BEGIN failed--compilation aborted at t/05-rr-rrsort.t line 8. # Looks like your test died before it could output anything. dubious Test returned status 255 (wstat 65280, 0xff00) Hope that helps,

Thu Nov 15 13:01:15 2007 a.r.ferreira [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #29558] Test-Simple-0.73 will break Net-DNS testsuite
Date:	Thu, 15 Nov 2007 16:00:37 -0200
To:	bug-Net-DNS [...] rt.cpan.org
From:	"Adriano Ferreira" <a.r.ferreira [...] gmail.com>

Dear Olaf, You find attached the necessary patch to fix the defect reported in this bug. It is very simple and has to do with a Test::Simple bug that worked as follows: 1. The " BEGIN { use_ok "Net::DNS" } " (which runs at compile time) happened before "plan tests => 22" (ordinary runtime) 2. So the "use_ok" should fail, because there was no plan yet 3. But it did not before the bug fix at Test::Simple -- it accepted silently the issue and test run to completion with a successful report So the fix is: + increment the number of tests to account for "use_ok" + make the plan run before "use_ok" -- in this case, by using "tests => 23" as arguments to "use Test::More" Kind regards, Adriano Ferreira diff -ru Net-DNS-0.61/t/05-rr-rrsort.t Net-DNS/t/05-rr-rrsort.t --- Net-DNS-0.61/t/05-rr-rrsort.t 2007-08-01 08:48:35.000000000 -0300 +++ Net-DNS/t/05-rr-rrsort.t 2007-11-15 15:49:09.000000000 -0200 @@ -1,8 +1,8 @@ # $Id: 05-rr-rrsort.t 616 2006-10-18 09:15:48Z olaf $ -*-perl-*- -use Test::More; +use Test::More tests => 23; use strict; -plan tests => 22; + BEGIN{ use_ok('Net::DNS', qw(rrsort)); };

Message body is not shown because sender requested not to inline it.

Thu Nov 15 13:01:19 2007 The RT System itself - Status changed from 'new' to 'open'

Sat Dec 22 00:42:50 2007 ANDK [...] cpan.org - Correspondence added

In case you haven't noticed, Test-Simple 0.74 is already released and now your test *is* broke. Ferreira's patch is now also available from my CPAN directory: ANDK/patches/Net-DNS-0.61-FERREIRA-01.patch.gz

Fri Dec 28 05:44:39 2007 OLAF [...] cpan.org - Correspondence added

Things should be OK for 0.62. Tested with Test::Simple 0.74

Fri Dec 28 05:44:47 2007 OLAF [...] cpan.org - Status changed from 'open' to 'resolved'