Bug #29486 for Games-Tournament-Swiss: downfloaters aren't recognised by C3

Wed Sep 19 05:13:36 2007 bartolin [...] gmx.de - Ticket created

Subject:	downfloaters aren't recognised by C3
Date:	Wed, 19 Sep 2007 11:12:13 +0200
To:	bug-Games-Tournament-Swiss [...] rt.cpan.org
From:	Christian Bartolomaeus <bartolin [...] gmx.de>

Hi, I stumbled about the following situation: Pairingtable: Round 5 Pairing Groups ------------------------------------------------------------------------- Place No Opponents Roles Float Score 1 8 18,5,3,1 BWBW D 3.5 2 1 11,10,6,8 WBWB U 3 3-9 2 12,7,9,5 BWBW 2.5 4 14,9,7,17 BWBW 2.5 5 15,8,13,2 WBWB 2.5 7 17,2,4,9 WBWB 2.5 9 19,4,2,7 WBWW 2.5 16 6,19,11,10 WBWB 2.5 17 7,14,18,4 BWBB d 2.5 10-14 3 13,6,8,11 WBWB u 2 6 16,3,1,15 BWBW 2 11 1,12,16,3 BWBW 2 13 3,18,5,19 BWBW 2 15 5,20,10,6 BWWB 2 15-16 10 20,1,15,16 BWBW 1.5 20 10,15,14,12 WBBW D 1.5 17-19 12 2,11,19,20 WBWB dU 1 18 8,13,17,14 WBWW u 1 19 9,16,12,13 BWBB u 1 20 14 4,17,20,18 WBWB 0 Now 1 is moved down to Bracket 2. There is no possible pairing, since 1 and 8 played in round 4 already. Therefore 1 and 8 are moved down to Bracket 3. For some reason, now Bracket 3 is recognised as 'heterogenous' by Bracket.pm (sub hetero), but the downfloaters aren't recognised in Bracket.pm (sub p). Therefore p is calculated wrongly (it should be 2) and S1 and S2 are wrong as well: Show quoted text

> Round 5: 8 (3.5), 1 (3), 2 4 5 7 9 16 17 (2.5), 3 6 11 13 15 (2), 10 20 (1.5), 12 18 19 (1), 14 (0), > Next, Bracket 1: 8 > C1, Bracket 1. Floating 8 Down, [1] 8 => [2] 8 1 > > Next, Bracket 2: 8 1 > C1, NOK. 8 1 > C12, Heterogenous group 1 now homogeneous > C14, Bracket 2, now p=0 > Moving down all Bracket 2, to 3. Bracket 2: 8 1 => Bracket 3: 1 8 2 4 5 7 9 16 17 > Next, Bracket 3: 1 8 2 4 5 7 9 16 17 > C1, B1,2 test: ok, no unpairables > C2, x=0 > C3, p=4 Heterogeneous. > C4, S1 & S2: 8 1 2 4 & 5 7 9 16 17

Best regards Christian

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Wed Sep 19 07:56:59 2007 drbean [...] freeshell.org - Correspondence added

Subject:	Re: [rt.cpan.org #29486] downfloaters aren't recognised by C3
Date:	Wed, 19 Sep 2007 11:54:22 +0000
To:	Christian Bartolomaeus via RT <bug-Games-Tournament-Swiss [...] rt.cpan.org>
From:	Greg Matheson <drbean [...] freeshell.org>

On Wed, 19 Sep 2007, Christian Bartolomaeus via RT wrote: Show quoted text

> For some reason, now Bracket 3 is recognised as 'heterogenous' by > Bracket.pm (sub hetero), but the downfloaters aren't recognised in > Bracket.pm (sub p). Therefore p is calculated wrongly (it should be > 2) and S1 and S2 are wrong as well:

Show quoted text

> > Moving down all Bracket 2, to 3. Bracket 2: 8 1 => Bracket 3: 1 8 2 4 5 7 9 16 17 > > Next, Bracket 3: 1 8 2 4 5 7 9 16 17 > > C1, B1,2 test: ok, no unpairables > > C2, x=0 > > C3, p=4 Heterogeneous. > > C4, S1 & S2: 8 1 2 4 & 5 7 9 16 17

Taking out this line from c14 method seems to fix this: $nextgroup->naturalize($_) for @evacuees;

Wed Sep 19 07:57:04 2007 The RT System itself - Status changed from 'new' to 'open'

Wed Sep 19 09:50:43 2007 bartolin [...] gmx.de - Correspondence added

Subject:	Re: [rt.cpan.org #29486] downfloaters aren't recognised by C3
Date:	Wed, 19 Sep 2007 15:50:28 +0200
To:	Greg Matheson via RT <bug-Games-Tournament-Swiss [...] rt.cpan.org>
From:	Christian Bartolomaeus <bartolin [...] gmx.de>

* On 2007-09-19 Greg Matheson via RT (bug-Games-Tournament-Swiss@rt.cpan.org) wrote: Show quoted text

> [...]

> > For some reason, now Bracket 3 is recognised as 'heterogenous' by > > Bracket.pm (sub hetero), but the downfloaters aren't recognised in > > Bracket.pm (sub p). Therefore p is calculated wrongly (it should be > > 2) and S1 and S2 are wrong as well:

>

> > > Moving down all Bracket 2, to 3. Bracket 2: 8 1 => Bracket 3: 1 8 2 4 5 7 9 16 17 > > > Next, Bracket 3: 1 8 2 4 5 7 9 16 17 > > > C1, B1,2 test: ok, no unpairables > > > C2, x=0 > > > C3, p=4 Heterogeneous. > > > C4, S1 & S2: 8 1 2 4 & 5 7 9 16 17

> > Taking out this line from c14 method seems to fix this: > > $nextgroup->naturalize($_) for @evacuees;

Yes, that works for me. By the way, I just discovered there seems to be a forum for Games::Tournament::Swiss at http://www.cpanforum.com/dist/Games-Tournament-Swiss Would it be appropriate to raise some questions there first before filing a bug report? (Though I have no problem with doing the latter.) Especially if its not really a bug report but rather a question about some internals of the module? Thanks Christian

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Sun Sep 30 05:56:11 2007 drbean [...] freeshell.org - Correspondence added

Subject:	Re: [rt.cpan.org #29486] downfloaters aren't recognised by C3
Date:	Sun, 30 Sep 2007 09:55:42 +0000
To:	Christian Bartolomaeus via RT <bug-Games-Tournament-Swiss [...] rt.cpan.org>
From:	Greg Matheson <drbean [...] freeshell.org>

On Wed, 19 Sep 2007, Christian Bartolomaeus via RT wrote: Show quoted text

> > Taking out this line from c14 method seems to fix this:

Show quoted text

> > $nextgroup->naturalize($_) for @evacuees;

I won't close this report yet. I can't remember why I was naturalizing the evacuees. Perhaps some other code will break later.. Show quoted text

> http://www.cpanforum.com/dist/Games-Tournament-Swiss

Show quoted text

> Would it be appropriate to raise some questions there first before > filing a bug report?

I don't think there is a need to use that yet. There are a lot of people monitoring that URL, but they seem to be monitoring a lot of cpanforum URLs, so I don't think they are particularly interested in the module.