Skip Menu |

This queue is for tickets about the File-Slurp CPAN distribution.

Report information
The Basics
Id: 29416
Status: resolved
Priority: 0/
Queue: File-Slurp

People
Owner: Nobody in particular
Requestors: cpan [...] pjedwards.co.uk
zakame [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: error.t handle.t large.t paragraph.t pseudo.t fail with version 0.71 of Test::Simple, use_ok before plan
Version 0.71 of Test::Simple has the bug fix: http://search.cpan.org/src/MSCHWERN/Test-Simple-0.71/Changes Bug fixes - Fixed a problem with BEGIN { use_ok } silently failing when there's no plan set. [rt.cpan.org 28345] Thanks Adriano Ferreira and Yitzchak. error.t handle.t large.t paragraph.t pseudo.t in File::Slurp now fail when using version 0.71 of Test::Simple because of the: BEGIN{ use_ok( 'File::Slurp', ) ; } before a plan is set. Thanks, Peter (Stig) Edwards
I've uploaded a patch that deals with this ANDK/patches/File-Slurp-9999.12-ANDK-03.patch.gz The patch leaves aside the (irrelevant) Fcntl prototype aspect that was already resolved in an earlier patch.
On Mon Sep 17 06:30:06 2007, cpan@pjedwards.co.uk wrote: Show quoted text
> Version 0.71 of Test::Simple has the bug fix: > > http://search.cpan.org/src/MSCHWERN/Test-Simple-0.71/Changes > > Bug fixes > - Fixed a problem with BEGIN { use_ok } silently failing when > there's no plan set. [rt.cpan.org 28345] Thanks Adriano > Ferreira and Yitzchak.
Hmm, the File::Slurp bug still seems to be present, even with version 0.74 of Test::Simple in Strawberry Perl.
From: polettix [...] cpan.org
On Wed Sep 19 22:49:56 2007, ANDK wrote: Show quoted text
> I've uploaded a patch that deals with this > > ANDK/patches/File-Slurp-9999.12-ANDK-03.patch.gz > > The patch leaves aside the (irrelevant) Fcntl prototype aspect that was > already resolved in an earlier patch.
I didn't find the earlier patch you're talking about, so I tried to figure it by myself. I just merged your patch with this slight change, and I'm attaching the whole patch, that can be applied against version 9999.12 of File::Slurp (don't know about other versions). Is the maintainer aware of these problems? I got them with a brand-new perl 5.10.0, so it's probable that many will be experiencing them in the near future. It's really funny that all issues with this module come from the test suite. Regards, Flavio.
Download File-Slurp-9999.12-patch.gz
application/x-gzip 1k

Message body not shown because it is not plain text.

On Wed Dec 26 11:14:56 2007, POLETTIX wrote: Show quoted text
> Is the > maintainer aware of these problems? I got them with a brand-new perl > 5.10.0, so it's probable that many will be experiencing them in the near > future.
Uri's email can be found: http://search.cpan.org/dist/File-Slurp/lib/File/Slurp.pm#AUTHOR, he responded to RT#27371 directly in June 2007.
fixed by removing use_ok calls. don't see the need for them anyhow.