Skip Menu |

This queue is for tickets about the Crypt-SSLeay CPAN distribution.

Report information
The Basics
Id: 29372
Status: resolved
Priority: 0/
Queue: Crypt-SSLeay
People
Owner: dland [...] cpan.org
Requestors: JDB [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 0.57

History Show all quoted text
  Fri Sep 14 14:33:28 2007 JDB [...] cpan.org - Ticket created
Subject: Erroneous assignment to $! in Net/SSL.pm
The connect method contains this code: # odd error in eval {} block, maybe alarm outside the evals if($@) { $! = "$@; $!"; croak($@); } The assignment should be to $@ and not to $! A little earlier we there is the following code: eval { $self->die_with_error("SSL negotiation failed") }; $@ = "$@; $!"; The assignment to $@ there becomes redundant once the code below is fixed.
  Sat Sep 15 04:39:26 2007 dland [...] cpan.org - Correspondence added
On Fri Sep 14 14:33:28 2007, JDB wrote: Show quoted text
> The connect method contains this code: > > # odd error in eval {} block, maybe alarm outside the evals > if($@) { > $! = "$@; $!"; > croak($@); > } > > The assignment should be to $@ and not to $! > > A little earlier we there is the following code: > > eval { $self->die_with_error("SSL negotiation failed") }; > $@ = "$@; $!"; > > The assignment to $@ there becomes redundant once the code below is fixed.
Hmmm, well that's all quite silly isn't it. Thanks for noticing this, I'll get it straightened out in the next release. Thanks, David
  Sat Sep 15 04:42:23 2007 dland [...] cpan.org - Correspondence added
On Fri Sep 14 14:33:28 2007, JDB wrote: Show quoted text
> The connect method contains this code: > > # odd error in eval {} block, maybe alarm outside the evals > if($@) { > $! = "$@; $!"; > croak($@); > } > > The assignment should be to $@ and not to $! > > A little earlier we there is the following code: > > eval { $self->die_with_error("SSL negotiation failed") }; > $@ = "$@; $!"; > > The assignment to $@ there becomes redundant once the code below is fixed.
Hmmm, well that's all quite silly isn't it. Thanks for noticing this, I'll get it straightened out in the next release. Thanks, David
  Sat Sep 15 04:43:13 2007 dland [...] cpan.org - Correspondence added
On Fri Sep 14 14:33:28 2007, JDB wrote: Show quoted text
> The connect method contains this code: > > # odd error in eval {} block, maybe alarm outside the evals > if($@) { > $! = "$@; $!"; > croak($@); > } > > The assignment should be to $@ and not to $! > > A little earlier we there is the following code: > > eval { $self->die_with_error("SSL negotiation failed") }; > $@ = "$@; $!"; > > The assignment to $@ there becomes redundant once the code below is fixed.
Hmmm, well that's all quite silly isn't it. Thanks for noticing this, I'll get it straightened out in the next release. Thanks, David
  Sat Sep 15 04:46:59 2007 The RT System itself - Status changed from 'new' to 'open'
  Sat Sep 15 04:46:59 2007 The RT System itself - Status changed from 'new' to 'open'
  Sat Sep 15 04:51:00 2007 The RT System itself - Status changed from 'new' to 'open'
  Sat Sep 15 05:04:03 2007 dland [...] cpan.org - Given to DLAND
  Sat Sep 15 05:17:55 2007 dland [...] cpan.org - Correspondence added
On Fri Sep 14 14:33:28 2007, JDB wrote: Show quoted text
> The connect method contains this code: > > # odd error in eval {} block, maybe alarm outside the evals > if($@) { > $! = "$@; $!"; > croak($@); > } > > The assignment should be to $@ and not to $! > > A little earlier we there is the following code: > > eval { $self->die_with_error("SSL negotiation failed") }; > $@ = "$@; $!"; > > The assignment to $@ there becomes redundant once the code below is fixed.
Hmmm, well that's all quite silly isn't it. Thanks for noticing this, I'll get it straightened out in the next release. Thanks, David
  Sat Sep 15 05:20:57 2007 dland [...] cpan.org - Correspondence added
On Sat Sep 15 05:17:55 2007, DLAND wrote: Show quoted text
> On Fri Sep 14 14:33:28 2007, JDB wrote:
> > The connect method contains this code: > > > > # odd error in eval {} block, maybe alarm outside the evals > > if($@) { > > $! = "$@; $!"; > > croak($@); > > } > > > > The assignment should be to $@ and not to $! > > > > A little earlier we there is the following code: > > > > eval { $self->die_with_error("SSL negotiation
failed") }; Show quoted text
> > $@ = "$@; $!"; > > > > The assignment to $@ there becomes redundant once the code below is
fixed. Show quoted text
> > Hmmm, well that's all quite silly isn't it. Thanks for noticing this, > I'll get it straightened out in the next release. > > Thanks, > David
Woah. Sorry about the 50 million replies. The RT server was just hanging there doing nothing... so I kept on trying. David
  Tue Sep 18 08:31:36 2007 dland [...] cpan.org - Fixed in 0.57 added
  Tue Sep 18 08:31:36 2007 dland [...] cpan.org - Correspondence added
Fixed in release 0.57. Thanks for the report. David Landgren
  Tue Sep 18 08:31:38 2007 dland [...] cpan.org - Status changed from 'open' to 'resolved'