Bug #29343 for Google-Adwords: Broken in ppm since 1.3.0

Thu Sep 13 12:51:46 2007 wruppert [...] responseb2b.com - Ticket created

Subject:

Broken in ppm since 1.3.0

See build results at: http://trouchelle.com/perl/ppmrepview.pl?l=Google%3A%3Aadwords Google now rejects API version in 1.2.3, so module is unusable for Win32 activestate users.

Thu Sep 13 13:30:40 2007 rohan [...] almeida.in - Correspondence added

From:

rohan [...] almeida.in

Hi, Can you please apply the attached patch to v1.5.0 ? It basically makes sure Date_Init() is called before using using any routines from Date::Manip (needed on win32 I guess). Please let me know if this works, so I can release this patch. Thanks, Rohan On Thu Sep 13 12:51:46 2007, wruppert wrote: Show quoted text

> See build results at: > http://trouchelle.com/perl/ppmrepview.pl?l=Google%3A%3Aadwords > > Google now rejects API version in 1.2.3, so module is unusable for Win32 > activestate users.

Index: lib/Google/Adwords/CampaignService.pm =================================================================== --- lib/Google/Adwords/CampaignService.pm (revision 1152) +++ lib/Google/Adwords/CampaignService.pm (working copy) @@ -222,6 +222,7 @@ #use Data::Dumper; #die Dumper $data; # format dates + Date_Init("TZ=EST5EDT"); $data->{'startDay'} = UnixDate( ParseDate( $data->{'startDay'} ), "%Y-%m-%d %H:%M:%S" ); $data->{'endDay'}

Thu Sep 13 13:30:44 2007 The RT System itself - Status changed from 'new' to 'open'

Thu Sep 13 22:45:18 2007 wruppert [...] charter.net - Correspondence added

Subject:	Re: [rt.cpan.org #29343] Broken in ppm since 1.3.0
Date:	Thu, 13 Sep 2007 21:44:18 -0500
To:	bug-Google-Adwords [...] rt.cpan.org
From:	Bill Ruppert <wruppert [...] charter.net>

Message body is not shown because it is too large.

Tue Mar 18 07:06:20 2008 rohan [...] almeida.in - Correspondence added

This should be fixed in the latest release 1.8.1 I've also disabled the live sandbox tests by default. Can you please test? -- Rohan

Tue Mar 18 07:06:31 2008 rohan [...] almeida.in - Status changed from 'open' to 'resolved'

Tue Mar 18 07:55:09 2008 wruppert [...] responseb2b.com - Correspondence added

Subject:	RE: [rt.cpan.org #29343] Broken in ppm since 1.3.0
Date:	Tue, 18 Mar 2008 06:54:47 -0500
To:	<bug-Google-Adwords [...] rt.cpan.org>
From:	"William A. Ruppert" <wruppert [...] responseb2b.com>

Hi, I use ActiveState ppms, so I'll have to wait until one of the repos gets updated. Regards, Bill Ruppert President, ResponseB2B http://www.responseb2b.com wruppert@responseb2b.com 817-542-3462 Show quoted text

-----Original Message----- From: Rohan Almeida via RT [mailto:bug-Google-Adwords@rt.cpan.org] Sent: Tuesday, March 18, 2008 6:06 AM To: wruppert@responseb2b.com Subject: [rt.cpan.org #29343] Broken in ppm since 1.3.0 <URL: http://rt.cpan.org/Ticket/Display.html?id=29343 > This should be fixed in the latest release 1.8.1 I've also disabled the live sandbox tests by default. Can you please test? -- Rohan

Tue Mar 18 07:55:10 2008 The RT System itself - Status changed from 'resolved' to 'open'

Thu Jan 29 07:03:56 2009 TIMB [...] cpan.org - Correspondence added

The patch isn't the right fix. * It's inappropriate to call Date_Init() in runtime code (it's expensive and has global effects) * It shouldn't be needed anyway as Date::Manip will cal it itself. * It's inappropriate to hard-wire the EST5EDT timezone. * It doesn't actually fix the warnings on some systems (like Mac OS X, I'm still looking into why)