Bug #29023 for Games-Tournament-Swiss: missing object method "urFloat" in FIDE.pm

Mon Aug 27 12:56:25 2007 bartolin [...] gmx.de - Ticket created

Subject:	missing object method "urFloat" in FIDE.pm
Date:	Mon, 27 Aug 2007 18:56:37 +0200
To:	bug-Games-Tournament-Swiss [...] rt.cpan.org
From:	Christian Bartolomaeus <bartolin [...] gmx.de>

Hi, testing the module Games::Tournament::Swiss with some notional tournaments I encountered an error regarding object method "urFloat" in FIDE.pm. The full output of $> perl pairstately follows: Round 3: 4 (2), 1 2 (1), 3 (0), Next, Bracket 1: 4 C1, Bracket 1. Floating 4 Down, [1] 4 => [2] 4 1 2 Next, Bracket 2: 4 1 2 C1, B1a: NOK. 4 C12, Use of uninitialized value in splice at /usr/local/share/perl/5.8.8/Games/Tournament/Swiss/Procedure/FIDE.pm line 1102. Unfloating Down 4, [-1] [-2] 4 4 1 2 Can't locate object method "urFloat" via package "Games::Tournament::Swiss::Procedure" at /usr/local/share/perl/5.8.8/Games/Tournament/Swiss/Procedure/FIDE.pm line 925. In this case it was a tournament with only 4 participants and 3 rounds. A bit extreme, but I think it shouldn't break the pairing algorithm. In this case, player 4 already played against players 1 and 2, so he had to be paired against player 3. I think I saw that particular error before when testing with more participants. If you need more informations or test cases I will gladly provide them. Best regards, Christian

Fri Aug 31 22:44:44 2007 drbean [...] freeshell.org - Correspondence added

Subject:	Re: [rt.cpan.org #29023] missing object method "urFloat" in FIDE.pm
Date:	Sat, 1 Sep 2007 02:44:08 +0000
To:	Christian Bartolomaeus via RT <bug-Games-Tournament-Swiss [...] rt.cpan.org>
From:	Greg Matheson <drbean [...] freeshell.org>

On Tue, 28 Aug 2007, Greg Matheson wrote: Show quoted text

> On Mon, 27 Aug 2007, Christian Bartolomaeus via RT wrote:

Show quoted text

> Round 3 Pairing Groups > ------------------------------------------------------------------------- > Place No Opponents Roles Float Score > 1 > 4 2,1 WW D 2 > 2-3 > 1 3,4 WB U 1 > 2 4,3 BW D 1 > 4 > 3 1,2 BB U 0

I just uploaded a new version of FIDE.pm which I think pairs this correctly. Can you try running the tests? t/foura.t should test it.

Fri Aug 31 22:44:46 2007 The RT System itself - Status changed from 'new' to 'open'

Sat Sep 01 01:59:49 2007 bartolin [...] gmx.de - Correspondence added

Subject:	Re: [rt.cpan.org #29023] missing object method "urFloat" in FIDE.pm
Date:	Sat, 1 Sep 2007 07:55:31 +0200
To:	Greg Matheson via RT <bug-Games-Tournament-Swiss [...] rt.cpan.org>
From:	Christian Bartolomaeus <bartolin [...] gmx.de>

* On 2007-08-31 Greg Matheson via RT (bug-Games-Tournament-Swiss@rt.cpan.org) wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=29023 > > > On Tue, 28 Aug 2007, Greg Matheson wrote: >

> > On Mon, 27 Aug 2007, Christian Bartolomaeus via RT wrote:

>

> > Round 3 Pairing Groups > > ------------------------------------------------------------------------- > > Place No Opponents Roles Float Score > > 1 > > 4 2,1 WW D 2 > > 2-3 > > 1 3,4 WB U 1 > > 2 4,3 BW D 1 > > 4 > > 3 1,2 BB U 0

> > I just uploaded a new version of FIDE.pm which I think pairs this correctly. > Can you try running the tests? t/foura.t should test it.

The new version does what one would expect (new pairings: 3-4, 1-2). The test works fine as well. Thanks! Christian

Sat Sep 01 03:21:00 2007 drbean [...] freeshell.org - Correspondence added

Subject:	Re: [rt.cpan.org #29023] missing object method "urFloat" in FIDE.pm
Date:	Sat, 1 Sep 2007 07:18:58 +0000
To:	Christian Bartolomaeus via RT <bug-Games-Tournament-Swiss [...] rt.cpan.org>
From:	Greg Matheson <drbean [...] freeshell.org>

On Sat, 01 Sep 2007, Christian Bartolomaeus via RT wrote: Show quoted text

> > I just uploaded a new version of FIDE.pm which I think pairs this correctly. > > Can you try running the tests? t/foura.t should test it.

Show quoted text

> The new version does what one would expect (new pairings: 3-4, 1-2). > The test works fine as well.

I'll close this bug.

Sat Sep 01 03:37:28 2007 DRBEAN [...] cpan.org - Correspondence added

Fixed by version 0.06. refactoring of c12, c14. A quirk is the pairing of an empty Bracket 2, before the successful pairing of all 4 players moved down to Bracket 3. This leaves an undefined match in the array of matches. Actually there are 2 undefined elements in the array. One for each of the first 2 brackets. The 3rd element is a reference to the array of the 2 matches in the 3rd bracket. This array with 2 undefined elements could be construed as a feature, rather than a bug, so I think I'm justified in closing this bug report. Still, the empty pairing in Bracket 2 is a quirk, ie somewhat surprising and unusual.

Sat Sep 01 03:37:30 2007 DRBEAN [...] cpan.org - Status changed from 'open' to 'resolved'