Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 28978
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: djerius [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: 1.072



Subject: Makefile fragment in Makefile.PL for tag target is malformed
The makefile fragment in Makefile.PL for the "tag" target contains spaces rather than tabs and includes a trailing \ on the last line of the fragment. These cause the Solaris version of make to exit, complaining of the syntax errors. The attached patch fixes these issues. Perl::Critic then proceeds to fail a series of tests (as noted in other bug reports), but at least it gets to the tests!
Subject: Perl-Critic-1.07.patch
# This is a patch for Perl-Critic-1.07.orig to update it to Perl-Critic-1.07 # # To apply this patch: # STEP 1: Chdir to the source directory. # STEP 2: Run the 'applypatch' program with this patch file as input. # # If you do not have 'applypatch', it is part of the 'makepatch' package # that you can fetch from the Comprehensive Perl Archive Network: # http://www.perl.com/CPAN/authors/Johan_Vromans/makepatch-x.y.tar.gz # In the above URL, 'x' should be 2 or higher. # # To apply this patch without the use of 'applypatch': # STEP 1: Chdir to the source directory. # STEP 2: Run the 'patch' program with this file as input. # #### End of Preamble #### #### Patch data follows #### diff -c 'Perl-Critic-1.07.orig/Makefile.PL' 'Perl-Critic-1.07/Makefile.PL' Index: ./Makefile.PL *** ./Makefile.PL Tue Aug 21 10:01:52 2007 --- ./Makefile.PL Fri Aug 24 11:56:17 2007 *************** *** 79,95 **** .PHONY: tags tags: ! ctags -f tags \ ! --recurse \ ! --totals \ ! \ ! --exclude=blib/ \ ! --exclude=t/lib \ ! --exclude=.svn \ ! --exclude='*~' \ ! \ ! --languages=Perl \ ! --langmap=Perl:+.t \ MAKE_FRAG } --- 79,95 ---- .PHONY: tags tags: ! ctags -f tags \ ! --recurse \ ! --totals \ ! \ ! --exclude=blib/ \ ! --exclude=t/lib \ ! --exclude=.svn \ ! --exclude='*~' \ ! \ ! --languages=Perl \ ! --langmap=Perl:+.t MAKE_FRAG } #### End of Patch data #### #### ApplyPatch data follows #### # Data version : 1.0 # Date generated : Fri Aug 24 12:00:11 2007 # Generated by : makepatch 2.00 # Recurse directories : Yes # p 'Makefile.PL' 3515 1187970977 0100644 #### End of ApplyPatch data #### #### End of Patch kit [created: Fri Aug 24 12:00:11 2007] #### #### Checksum: 70 1888 2080 ####
From: ELLIOTJS [...] cpan.org
On Fri Aug 24 12:08:31 2007, DJERIUS wrote: Show quoted text
> The makefile fragment in Makefile.PL for the "tag" target contains > spaces rather than tabs and includes a trailing \ on the last line of > the fragment. These cause the Solaris version of make to exit, > complaining of the syntax errors.
A fixed version of this has just been checked into the code repository. This did not make it into the just released 1.071 version. Once reports come from that, I'll release another minor release in a few days. In the mean time, try the version attached here and make sure it works.
####################################################################### # $URL: http://perlcritic.tigris.org/svn/perlcritic/branches/Perl-Critic-1.xxx/Makefile.PL $ # $Date: 2007-08-24 09:23:28 -0700 (Fri, 24 Aug 2007) $ # $Author: clonezone $ # $Revision: 1843 $ # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab : ######################################################################## use strict; use warnings; use ExtUtils::MakeMaker; my $warning = <<'END_WARNING'; ################################################### # NOTICE! NOTICE! NOTICE! NOTICE! NOTICE! NOTICE! # #-------------------------------------------------# # In this version of Perl::Critic, some of # # the Policy modules have been renamed to better # # better reflect the intent of the Policy. If # # you have an older version of Perl::Critic # # already installed, it will cause many of the # # tests to fail and the new version will not work # # properly. # # # # I strongly advise you to remove the current # # version of Perl::Critic before proceeding with # # this installation. In most cases, this can be # # done by deleting everything below the # # Perl/Critic/Policy directory in your site_perl # # location. # # # # Also, if you have created a .perlcriticrc file, # # you will need to update it to match the new # # Policy module names. # # # # Sorry for the inconvenience. # # # # -Jeff <thaljef@cpan.org> # ################################################### END_WARNING eval { require Perl::Critic; warn $warning if $Perl::Critic::VERSION < 0.14; }; WriteMakefile( NAME => 'Perl::Critic', AUTHOR => 'Jeffrey Thalhammer <thaljef@cpan.org>', ABSTRACT_FROM => 'lib/Perl/Critic.pm', VERSION_FROM => 'lib/Perl/Critic.pm', EXE_FILES => ['bin/perlcritic'], PL_FILES => {}, PREREQ_PM => { 'B::Keywords' => 1.05, 'Config::Tiny' => 2, 'File::Spec' => 0, 'File::Spec::Unix' => 0, 'IO::String' => 0, 'List::MoreUtils' => 0, 'List::Util' => 0, 'Module::Pluggable' => 3.1, 'PPI' => 1.118, 'Pod::PlainText' => 0, 'Pod::Usage' => 0, 'Readonly' => 1.03, 'Scalar::Util' => 0, 'String::Format' => 1.13, 'Test::More' => 0, }, ); sub MY::postamble { return <<"MAKE_FRAG"; .PHONY: tags tags: \tctags -f tags \\ \t\t--recurse \\ \t\t--totals \\ \t\t\\ \t\t--exclude=blib/ \\ \t\t--exclude=t/lib \\ \t\t--exclude=.svn \\ \t\t--exclude='*~' \\ \t\t\\ \t\t--languages=Perl \\ \t\t--langmap=Perl:+.t MAKE_FRAG } ############################################################################## # Local Variables: # mode: cperl # cperl-indent-level: 4 # fill-column: 78 # indent-tabs-mode: nil # c-indentation-style: bsd # End: # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab :
Subject: Re: [rt.cpan.org #28978] Makefile fragment in Makefile.PL for tag target is malformed
Date: Fri, 24 Aug 2007 13:52:29 -0400
To: bug-Perl-Critic [...] rt.cpan.org
From: Diab Jerius <dj [...] head.cfa.harvard.edu>
On Fri, 2007-08-24 at 12:26 -0400, via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=28978 > > > On Fri Aug 24 12:08:31 2007, DJERIUS wrote:
> > The makefile fragment in Makefile.PL for the "tag" target contains > > spaces rather than tabs and includes a trailing \ on the last line of > > the fragment. These cause the Solaris version of make to exit, > > complaining of the syntax errors.
> > A fixed version of this has just been checked into the code > repository. This did not make it into the just released 1.071 version. > Once reports come from that, I'll release another minor release > in a few days. In the mean time, try the version attached here and make sure it works.
That does indeed work. I'll await the next release to see if the tests pass. Thanks, Diab
From: ELLIOTJS [...] cpan.org
On Fri Aug 24 14:23:07 2007, dj@head.cfa.harvard.edu wrote: Show quoted text
> That does indeed work. I'll await the next release to see if the > tests pass.
Thank you for taking the time to report this and to test the modified version.
From: ELLIOTJS [...] cpan.org
Just released 1.072, which includes this fix.
This was fixed in the 1.072 release.