| Subject: | t/06_invocant.t includes incorrect test |
Release 0.28 of Params-Util
t/06_invocant.t includes test code like:
SKIP: {
unless ( $ENV{AUTOMATED_TESTING} ) {
skip("Skipping nasty test unless AUTOMATED_TESTING", 1);
}
is( _INVOCANT($false_obj2), 1, 'Testing null class as an
invocant' );
}
Unfortunately, it looks like whoever moved this test out of @data didn't
reproduce the test correctly.
_INVOCANT() is documented as returning the original object, but this
code checks that it returns 1.
I've included a patch that changes the is(..., 1, ...) to an ok() to
match the conditional test done for the tests in @data, but this could
also be done as is(_INVOCANT($false_obj2), $false_obj2, ...)
Currently this bug means that Params::Util is failing whenever
AUTOMATED_TESTING is on, so you're not getting the benefit of automated
tests for any distribution that depends on Params::Util.
| Subject: | params-util-invocant.diff |
Only in Params-Util-0.28/: Makefile.old
diff -ru Params-Util-0.28-orig/t/06_invocant.t Params-Util-0.28/t/06_invocant.t
--- Params-Util-0.28-orig/t/06_invocant.t 2007-08-18 21:09:21.000000000 +1000
+++ Params-Util-0.28/t/06_invocant.t 2007-08-23 11:41:47.000000000 +1000
@@ -48,7 +48,7 @@
unless ( $ENV{AUTOMATED_TESTING} ) {
skip("Skipping nasty test unless AUTOMATED_TESTING", 1);
}
- is( _INVOCANT($false_obj2), 1, 'Testing null class as an invocant' );
+ ok( _INVOCANT($false_obj2), 'Testing null class as an invocant' );
}
package Params::Util::Test::_INVOCANT::Tied;