Bug #28941 for GRID-Machine: GRID::Machine correction

Wed Aug 22 14:56:12 2007 xoid [...] eml.cc - Ticket created

Subject:	GRID::Machine correction
Date:	Wed, 22 Aug 2007 14:55:49 -0400
To:	bug-GRID-Machine [...] rt.cpan.org
From:	Dmitriy Kargapolov <xoid [...] eml.cc>

Hi, First of all thanks for nice module - I did similar things (perl - ssh - perl) "manually" and now pretty much routine coding well done in GRID::Machine. I found one almost bug - almost since it's not fatal, but annoying with warnings. When use remotelibs property in constructor more than once (in a loop for example) internal code (Machine.pm line 637) adds the list of remote libraries to private static list @Remote_modules creating duplicate entries, so when code is transferred to remote machine(s) you'll get warnings about things already defined. I'm not sure why @Remote_modules is not property of object _instance_ - that could solve the problem. Also I have suggestions about adding 'callbacks', when remote code can call local subroutines - I did this as light addition to GRID::Machine in my code - let me know if you are interested in. Sincerely, Dmitriy Kargapolov.

Sat Sep 01 08:42:08 2007 CASIANO [...] cpan.org - Correspondence added

From:

CASIANO [...] cpan.org

Many Thanks Dmitriy, I have just arrived from YAPC in Vienna. Show quoted text

> When use remotelibs property in constructor more than once (in a loop > for example) internal code (Machine.pm line 637) adds the list of remote > libraries to private static list @Remote_modules creating duplicate > entries, so when code is transferred to remote machine(s) you'll get > warnings about things already defined.

Thank you very much. I will do it. Show quoted text

>I'm not sure why @Remote_modules is not property of object _instance_ - > that could solve the problem.

Yes! Seems better. Show quoted text

> Also I have suggestions about adding 'callbacks', when remote code can > call local subroutines - I did this as light addition to GRID::Machine > in my code - let me know if you are interested in.

Indeed! Please tell me I haven't worked for a month in GRID::Machine and I'll be busy during the incoming days but promise to introduce your changes and suggestions asap. You can contact me in casiano at ull dot es Best wishes

Sat Sep 01 08:42:10 2007 The RT System itself - Status changed from 'new' to 'open'

Thu Sep 06 11:10:06 2007 CASIANO [...] cpan.org - Correspondence added

Show quoted text

> > When use remotelibs property in constructor more than once (in a loop > > for example) internal code (Machine.pm line 637) adds the list of remote > > libraries to private static list @Remote_modules creating duplicate > > entries, so when code is transferred to remote machine(s) you'll get > > warnings about things already defined.

This bug seems to be fixed. Many thanks Casiano

Thu Sep 06 11:10:14 2007 CASIANO [...] cpan.org - Status changed from 'open' to 'resolved'