Bug #28940 for DBIx-Class-Schema-Loader: D::C::S::L hardcodes 'Core'

Wed Aug 22 14:30:23 2007 lanny [...] cisco.com - Ticket created

Subject:	D::C::S::L hardcodes 'Core'
Date:	Wed, 22 Aug 2007 13:29:24 -0500
To:	bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From:	Lanny Ripple <lanny [...] cisco.com>

This is somewhere between a bug and feature request. When using DBIx::Class::Schema::Loader's make_schema_at() the output schema always includes 'Core' in the __PACKAGE__->load_components("Core"); line. My group uses our own Core to cut down on the clutter loading it like __PACKAGE__->load_components("+CDB::DBIx::Core"); Since D::C::S::L::Base hardcodes the string 'Core' we have worked around this by exploding our core and listing all the components individually. This is troublesome Please provide an option to specify the core to be used rather than using a hardcoded value (with 'Core' as the obvious default). Thanks, -ljr __Details__ Distribution Name: DBIx-Class-Schema-Loader-0.04002 perl -v: This is perl, v5.8.6 built for sun4-solaris uname -a: SunOS squirrel 5.8 Generic_117350-34 sun4u sparc SUNW,Ultra-Enterprise -- Lanny Ripple <lanny@cisco.com> ScmDB / Cisco Systems, Inc.

Thu Aug 23 21:10:54 2007 dbix-class [...] trout.me.uk - Correspondence added

Subject:	Re: [rt.cpan.org #28940] D::C::S::L hardcodes 'Core'
Date:	Fri, 24 Aug 2007 01:39:00 +0100
To:	Lanny Ripple via RT <bug-DBIx-Class-Schema-Loader [...] rt.cpan.org>
From:	Matt S Trout <dbix-class [...] trout.me.uk>

On Wed, Aug 22, 2007 at 02:30:25PM -0400, Lanny Ripple via RT wrote: Show quoted text

> > Wed Aug 22 14:30:23 2007: Request 28940 was acted upon. > Transaction: Ticket created by lanny@cisco.com > Queue: DBIx-Class-Schema-Loader > Subject: D::C::S::L hardcodes 'Core' > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: lanny@cisco.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=28940 > > > > This is somewhere between a bug and feature request. > > When using DBIx::Class::Schema::Loader's make_schema_at() the > output schema always includes 'Core' in the > > __PACKAGE__->load_components("Core"); > > line. My group uses our own Core to cut down on the clutter > loading it like > > __PACKAGE__->load_components("+CDB::DBIx::Core"); > > Since D::C::S::L::Base hardcodes the string 'Core' we have worked > around this by exploding our core and listing all the components > individually. This is troublesome > > Please provide an option to specify the core to be used rather > than using a hardcoded value (with 'Core' as the obvious default).

Actually, in that case even better would be providing an option to change the base class itself - using CDB::DBIx::Core in the "use base" would likely improve your loading times. Schema::Loader subversion is at http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class-Schema-Loader A patch for this with tests would almost certainly be accepted. -- Matt S Trout Need help with your Catalyst or DBIx::Class project? Technical Director Want a managed development or deployment platform? Shadowcat Systems Ltd. Contact mst (at) shadowcatsystems.co.uk for a quote http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/

Thu Aug 23 21:10:57 2007 The RT System itself - Status changed from 'new' to 'open'

Mon Nov 30 20:29:29 2009 rkitover [...] cpan.org - Correspondence added

Current and 0.04999_12 now default to use base 'DBIx::Class::Core'; and no ->load_components . And you can change your result_base_class .

Mon Nov 30 20:29:30 2009 rkitover [...] cpan.org - Status changed from 'open' to 'resolved'