Skip Menu |

This queue is for tickets about the GnuPG-Interface CPAN distribution.

Report information
The Basics
Id: 28814
Status: resolved
Priority: 0/
Queue: GnuPG-Interface
People
Owner: Nobody in particular
Requestors: rzielinski [...] venda.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in:
  • 0.33
  • 0.35
Fixed in: (no value)

History Show all quoted text
  Mon Aug 13 11:47:40 2007 rzielinski [...] venda.com - Ticket created
Subject: avoid "use English;" regex performance penalty [patch]
GnuPG::Interface uses "use English;"; whithout -no_match_vars this causes a regex performance penalty. Solution: "use English qw( -no_match_vars );" instead.
Subject: Gnupg-Interface.patch
diff -urN GnuPG-Interface-0.35.orig/lib/GnuPG/Interface.pm GnuPG-Interface-0.35/lib/GnuPG/Interface.pm --- GnuPG-Interface-0.35.orig/lib/GnuPG/Interface.pm 2007-04-24 14:44:54.000000000 +0100 +++ GnuPG-Interface-0.35/lib/GnuPG/Interface.pm 2007-08-13 16:30:52.035110642 +0100 @@ -14,7 +14,7 @@ package GnuPG::Interface; use strict; -use English; +use English qw( -no_match_vars ); use Carp; use Fcntl; use vars qw( $VERSION ); diff -urN GnuPG-Interface-0.35.orig/Makefile.PL GnuPG-Interface-0.35/Makefile.PL --- GnuPG-Interface-0.35.orig/Makefile.PL 2007-04-20 17:42:11.000000000 +0100 +++ GnuPG-Interface-0.35/Makefile.PL 2007-08-13 16:23:10.605504601 +0100 @@ -1,7 +1,7 @@ use 5.005; use strict; -use English; +use English qw( -no_match_vars ); use ExtUtils::MakeMaker; use File::Find; diff -urN GnuPG-Interface-0.35.orig/t/clearsign.t GnuPG-Interface-0.35/t/clearsign.t --- GnuPG-Interface-0.35.orig/t/clearsign.t 2007-04-20 17:38:55.000000000 +0100 +++ GnuPG-Interface-0.35/t/clearsign.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/decrypt.t GnuPG-Interface-0.35/t/decrypt.t --- GnuPG-Interface-0.35.orig/t/decrypt.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/decrypt.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use File::Compare; use lib './t'; diff -urN GnuPG-Interface-0.35.orig/t/detach_sign.t GnuPG-Interface-0.35/t/detach_sign.t --- GnuPG-Interface-0.35.orig/t/detach_sign.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/detach_sign.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/encrypt_symmetrically.t GnuPG-Interface-0.35/t/encrypt_symmetrically.t --- GnuPG-Interface-0.35.orig/t/encrypt_symmetrically.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/encrypt_symmetrically.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/encrypt.t GnuPG-Interface-0.35/t/encrypt.t --- GnuPG-Interface-0.35.orig/t/encrypt.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/encrypt.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/export_keys.t GnuPG-Interface-0.35/t/export_keys.t --- GnuPG-Interface-0.35.orig/t/export_keys.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/export_keys.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/get_public_keys.t GnuPG-Interface-0.35/t/get_public_keys.t --- GnuPG-Interface-0.35.orig/t/get_public_keys.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/get_public_keys.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/get_secret_keys.t GnuPG-Interface-0.35/t/get_secret_keys.t --- GnuPG-Interface-0.35.orig/t/get_secret_keys.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/get_secret_keys.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/import_keys.t GnuPG-Interface-0.35/t/import_keys.t --- GnuPG-Interface-0.35.orig/t/import_keys.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/import_keys.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/list_public_keys.t GnuPG-Interface-0.35/t/list_public_keys.t --- GnuPG-Interface-0.35.orig/t/list_public_keys.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/list_public_keys.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use IO::File; use lib './t'; diff -urN GnuPG-Interface-0.35.orig/t/list_secret_keys.t GnuPG-Interface-0.35/t/list_secret_keys.t --- GnuPG-Interface-0.35.orig/t/list_secret_keys.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/list_secret_keys.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/list_sigs.t GnuPG-Interface-0.35/t/list_sigs.t --- GnuPG-Interface-0.35.orig/t/list_sigs.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/list_sigs.t 2007-08-13 16:23:10.605504601 +0100 @@ -3,7 +3,7 @@ # $Id: list_sigs.t,v 1.7 2001/05/03 06:00:06 ftobin Exp $ use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/MyTest.pm GnuPG-Interface-0.35/t/MyTest.pm --- GnuPG-Interface-0.35.orig/t/MyTest.pm 2001-08-21 14:31:50.000000000 +0100 +++ GnuPG-Interface-0.35/t/MyTest.pm 2007-08-13 16:23:10.605504601 +0100 @@ -16,7 +16,7 @@ package MyTest; use strict; -use English; +use English qw( -no_match_vars ); use Exporter; use IO::File; use vars qw( @ISA @EXPORT ); diff -urN GnuPG-Interface-0.35.orig/t/MyTestSpecific.pm GnuPG-Interface-0.35/t/MyTestSpecific.pm --- GnuPG-Interface-0.35.orig/t/MyTestSpecific.pm 2001-08-21 14:31:50.000000000 +0100 +++ GnuPG-Interface-0.35/t/MyTestSpecific.pm 2007-08-13 16:23:10.605504601 +0100 @@ -14,7 +14,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use Fatal qw/ open close /; use IO::File; use IO::Handle; diff -urN GnuPG-Interface-0.35.orig/t/passphrase_handling.t GnuPG-Interface-0.35/t/passphrase_handling.t --- GnuPG-Interface-0.35.orig/t/passphrase_handling.t 2001-05-03 07:02:39.000000000 +0100 +++ GnuPG-Interface-0.35/t/passphrase_handling.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use Symbol; use IO::File; diff -urN GnuPG-Interface-0.35.orig/t/sign_and_encrypt.t GnuPG-Interface-0.35/t/sign_and_encrypt.t --- GnuPG-Interface-0.35.orig/t/sign_and_encrypt.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/sign_and_encrypt.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/sign.t GnuPG-Interface-0.35/t/sign.t --- GnuPG-Interface-0.35.orig/t/sign.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/sign.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest; diff -urN GnuPG-Interface-0.35.orig/t/verify.t GnuPG-Interface-0.35/t/verify.t --- GnuPG-Interface-0.35.orig/t/verify.t 2001-05-03 07:00:06.000000000 +0100 +++ GnuPG-Interface-0.35/t/verify.t 2007-08-13 16:23:10.605504601 +0100 @@ -4,7 +4,7 @@ # use strict; -use English; +use English qw( -no_match_vars ); use lib './t'; use MyTest;
  Mon Aug 13 12:27:40 2007 jesse [...] fsck.com - Correspondence added
CC: undisclosed-recipients: ;
Subject: Re: [rt.cpan.org #28814] avoid "use English;" regex performance penalty [patch]
Date: Mon, 13 Aug 2007 12:27:35 -0400
To: Radoslaw Zielinski via RT <bug-GnuPG-Interface [...] rt.cpan.org>
From: jesse <jesse [...] fsck.com>
On Mon, Aug 13, 2007 at 11:47:45AM -0400, Radoslaw Zielinski via RT wrote: Show quoted text
> > Mon Aug 13 11:47:40 2007: Request 28814 was acted upon. > Transaction: Ticket created by mehradek > Queue: GnuPG-Interface > Subject: avoid "use English;" regex performance penalty [patch] > Broken in: (no value) > Severity: Important > Owner: Nobody > Requestors: rzielinski@venda.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=28814 > > > > GnuPG::Interface uses "use English;"; whithout -no_match_vars this > causes a regex performance penalty. Solution: "use English qw( > -no_match_vars );" instead.
Thanks! Applied. Released. --
  Mon Aug 13 12:27:42 2007 The RT System itself - Status changed from 'new' to 'open'
  Thu Jun 05 12:07:10 2008 RUZ [...] cpan.org - Status changed from 'open' to 'resolved'