Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the ack CPAN distribution.

Maintainer(s)' notes

ack's issues are tracked at https://github.com/petdance/ack2

Report information
The Basics
Id: 28786
Status: resolved
Priority: 0/
Queue: ack

People
Owner: Nobody in particular
Requestors: rjk [...] tamias.net
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.64
Fixed in: (no value)



Subject: [patch] Test failure when creating debian package
While trying to create a debian package of ack, we encountered the following test failure: # Failed test 'Looking for g$' # at t/ack-g.t line 74. # Structures begin differing at: # $got->[0] = 'debian/changelog' # $expected->[0] = 't/swamp/moose-andy.jpg' As you can see, the debian directory that is created as part of the process interferes with the test. I think a reasonable fix would be to have all the tests only search within the t/ directory. Most of the tests already do that; the attached patch updates the two tests in ack-g.t that didn't.
Subject: ack_test.patch
--- t/ack-g.t~ 2007-08-10 12:48:49.000000000 -0400 +++ t/ack-g.t 2007-08-10 12:53:21.000000000 -0400 @@ -45,11 +45,11 @@ FRONT_ANCHOR: { my @expected = qw( - squash + t/standalone.t ); - my $regex = '^s'; + my $regex = '^t/st'; - my @files = qw( . ); + my @files = qw( t ); my @args = ( '-g', $regex ); my $cmd = "$^X ./ack-standalone @args @files"; my @results = `$cmd`; @@ -65,7 +65,7 @@ ); my $regex = 'g$'; - my @files = qw( . ); + my @files = qw( t ); my @args = ( '-a', '-g', $regex ); my $cmd = "$^X ./ack-standalone @args @files"; my @results = `$cmd`;
Subject: Re: [rt.cpan.org #28786] [patch] Test failure when creating debian package
Date: Fri, 10 Aug 2007 13:22:20 -0500
To: "rjk-cpan [...] tamias.net via RT" <bug-ack [...] rt.cpan.org>
From: Andy Lester <andy [...] petdance.com>
Show quoted text
> While trying to create a debian package of ack, we encountered the > following test failure: > > # Failed test 'Looking for g$' > # at t/ack-g.t line 74. > # Structures begin differing at: > # $got->[0] = 'debian/changelog' > # $expected->[0] = 't/swamp/moose-andy.jpg' > > As you can see, the debian directory that is created as part of the > process interferes with the test.
Thanks for the patch. I've applied it and it will be in 1.66. xoxo, Andy -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance
This should be fixed.