Skip Menu |

This queue is for tickets about the HTML-Tree CPAN distribution.

Report information
The Basics
Id: 28404
Status: resolved
Priority: 0/
Queue: HTML-Tree

People
Owner: Jeff.Fearn [...] gmail.com
Requestors: daxim [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 3.23
Fixed in: (no value)



Subject: tests fail when PERL_UNICODE is set
I have PERL_UNICODE=ASDL set (see perlrun). Attached log was produced by make test TEST_VERBOSE=1 > make-test-test-verbose.log 2>&1 Binmode your binary files. diff -ru HTML-Tree-3.23~/t/construct_tree.t HTML-Tree-3.23/t/construct_tree.t --- HTML-Tree-3.23~/t/construct_tree.t 2006-08-04 06:50:10.000000000 +0200 +++ HTML-Tree-3.23/t/construct_tree.t 2007-07-20 17:10:51.000000000 +0200 @@ -18,6 +18,7 @@ { local $/ = undef ; open(INFILE, $TestInput) || die "Can't open $TestInput: $!"; + binmode INFILE; $HTML=<INFILE> ; close(INFILE) ; } @@ -44,6 +45,7 @@ # Filehandle Test { open(INFILE, $TestInput) || die "Can't open $TestInput: $!"; + binmode INFILE; my $file_obj = HTML::Tree->new_from_file( *INFILE ); test_new_obj($file_obj, "new_from_file Filehandle" ) ; close(INFILE); diff -ru HTML-Tree-3.23~/t/oldparse.t HTML-Tree-3.23/t/oldparse.t --- HTML-Tree-3.23~/t/oldparse.t 2006-08-04 06:50:11.000000000 +0200 +++ HTML-Tree-3.23/t/oldparse.t 2007-07-20 17:12:02.000000000 +0200 @@ -17,6 +17,7 @@ { local $/ = undef ; open("INFILE", "$TestInput") || die "$!" ; + binmode INFILE; $HTML=<INFILE> ; close(INFILE) ; }
Subject: make-test-test-verbose.log

Message body is not shown because it is too large.

Added bin mode to tests. http://github.com/jfearn/HTML-Tree
Subject: 4.0 released
Hi HTML::Tree ve4rsion 4.0 has been released which includes a fix for this issue. Cheers, Jeff.