Skip Menu |

This queue is for tickets about the Pod-S5 CPAN distribution.

Report information
The Basics
Id: 28391
Status: resolved
Priority: 0/
Queue: Pod-S5

People
Owner: tlinden [...] cpan.org
Requestors: avar [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.07
Fixed in: (no value)



Subject: [PATCH] bugs in S5.pm make S::H::E::Kate not work
AUTOLOAD was catching DESTROY and the syntax highlight table was constructed as %highlight = { ... } not %highlight = ( ... ). These issues caused syntax highlighting not to work under any circumstances.
Subject: Pod-S5-bugs.patch
diff -ru Pod-S5-0.07/S5.pm Pod-S5/S5.pm --- Pod-S5-0.07/S5.pm 2007-03-30 12:54:10.000000000 +0000 +++ Pod-S5/S5.pm 2007-07-20 01:31:45.000000000 +0000 @@ -83,7 +83,7 @@ # used for syntax highlighting, if Syntax::Highlight::Engine::Kate # is installed and the Code in question is supported -%highlite = { +%highlite = ( Alert => ['<font color="#0000ff">', '</font>'], BaseN => ['<font color="#007f00">', '</font>'], BString => ['<font color="#c9a7ff">', '</font>'], @@ -104,7 +104,7 @@ String => ['<font color="#ff0000">', '</font>'], Variable => ['<font color="#0000ff"><b>', '</b></font>'], Warning => ['<font color="#0000ff"><b><i>', '</font>'], - }; + ); $substitutions = { '<' => '&lt;', @@ -487,6 +487,9 @@ return; } +# Here so AUTOLOAD won't catch DESTROY +sub DESTROY {} + sub AUTOLOAD { # here comes the magic, we catch the formatter sub # called by walker() containing the highlite syntax Binary files Pod-S5-0.07/t/test/s5.zip and Pod-S5/t/test/s5.zip differ
Thanks for the patch its applied in 0.08.