Skip Menu |

This queue is for tickets about the Template-Alloy CPAN distribution.

Report information
The Basics
Id: 28280
Status: resolved
Priority: 0/
Queue: Template-Alloy
People
Owner: Nobody in particular
Requestors: TINITA [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Unimportant
Broken in: 1.006
Fixed in: (no value)
Attachments
patch

History Show all quoted text
  Mon Jul 16 05:54:11 2007 TINITA [...] cpan.org - Ticket created
Subject: bench_various_templaters.pl mistakes
hi, samples/benchmark/bench_various_templaters.pl has some mistakes. HTML::Template(::Compiled) have an option case_sensitive, not CASE_SENSITIVE. the option for file caching in HTML::Template::Compiled is called cache_dir, not file_cache_dir (i admit this is bad naming, i should probably change it). regards, tina
  Mon Jul 16 06:10:37 2007 TINITA [...] cpan.org - Correspondence added
i have attached a patchfile.
Download patch
application/octet-stream 3.7k

Message body not shown because it is not plain text.

  Mon Jul 16 06:10:45 2007 TINITA [...] cpan.org - Status changed from 'new' to 'open'
  Mon Jul 16 12:22:57 2007 paul [...] seamons.com - Correspondence added
Thank you for the patch. It will be included in the 1.007 release. I'm not sure I have anything pending for release right now so I'm not sure when 1.007 will come out. The patch increased the performance of HTC_file by 5 to 6 times. HTML::Template::Compiled is a great benchmark to be shooting for. For in memory templates - it is very - very fast!
  Mon Jul 30 18:06:29 2007 TINITA [...] cpan.org - Correspondence added
On Mo. 16. Jul. 2007, 05:54:11, TINITA wrote: Show quoted text
> the option for file caching in HTML::Template::Compiled is called > cache_dir, not file_cache_dir (i admit this is bad naming, i should > probably change it).
i fixed this in version 0.87 and works like in HTML::Template now.
  Fri Nov 02 11:17:40 2007 paul [...] seamons.com - Correspondence added
I think the latest is now in sync.
  Fri Nov 02 11:36:49 2007 paul [...] seamons.com - Correspondence added
I think the latest is now in sync.
  Fri Nov 02 11:36:53 2007 paul [...] seamons.com - Status changed from 'open' to 'resolved'
  Mon Nov 05 05:12:42 2007 TINITA [...] cpan.org - Correspondence added
From: cpan2 [...] tinita.de
On Fr. 02. Nov. 2007, 11:36:49, RHANDOM wrote: Show quoted text
> I think the latest is now in sync.
still, the samples/benchmark/bench_various_templaters.pl stats seem to be the old ones...
  Mon Nov 05 05:12:49 2007 The RT System itself - Status changed from 'resolved' to 'open'
  Mon Nov 05 10:51:30 2007 paul [...] seamons.com - Correspondence added
If you will check that the code is either in compliance with your most recent changes to HTML::Template::Compiled, and send me a patch if they are not (send me the patch for the proper parameters to be using for the string ref, file cache, and in memory tests) -- then I will apply any patches rerun the tests and release an updated Alloy.
  Mon Nov 05 12:09:09 2007 TINITA [...] cpan.org - Correspondence added
From: cpan2 [...] tinita.de
On Mo. 05. Nov. 2007, 10:51:30, RHANDOM wrote: Show quoted text
> If you will check that the code is either in compliance [...]
no sorry, i meant the SAMPLE OUTPUT section in bench_various_templaters.pl. the code seems to be ok, only the example results didn't change =)
  Thu Sep 18 12:18:17 2008 paul [...] seamons.com - Correspondence added
The results were updated on Nov 7 - two days after the request a year ago. I think everything should be in working order. And a test today recorded nearly the same results on the same computer.
  Thu Sep 18 12:18:19 2008 paul [...] seamons.com - Status changed from 'open' to 'resolved'