Skip Menu |

This queue is for tickets about the svk CPAN distribution.

Report information
The Basics
Id: 28126
Status: new
Priority: 0/
Queue: svk

People
Owner: Nobody in particular
Requestors: drow [...] openfoundry.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: v2.0.0
Fixed in: (no value)



Subject: Hang after failed pre-commit hook
===================== NOTE ===================== === We are in the process moving bug entries === === from rt.openfoundry.org to rt.cpan.org === === We apologize for any inconvenience === ================================================ Created Date: 2007-02-06 23:10:51 UTC Original No : #27428 I have a pre-commit hook that is supposed to prevent anyone but a particular user from committing to a mirrored directory; this was a compromise since I couldn't easily detect svk sync versus svk commit. I'd forgotten about the hook. So, when I went to test svk 2.0.0 before deploying it, I synced as the wrong user. Instead of the error message, SVK hangs :-( There are two processes left. One of them is in SVK::Mirror::Backend::SVNRaPipe::DESTROY, calling wait. The other (being waited for) is blocked in write(): write(8, "\0\0\0008\5\6\2\0\0\0\4\5\n\nclose_file\10\213\n 0162"..., 60 <unfinished ...> So it isn't exiting and can't be waited for. I think that either something should have read the last bit of the retrieved revision, or else DESTROY needs to do something more aggressive than just wait for the new process to exit (i.e. kill it). It's already cleaned up the transaction and seems to have removed locks by this point.