| Subject: | 1.01 introduces bug (test#6 failes) |
I noticed this modules 1.01 rev in the cpan-daily list, and clicked on it to see what it was.
I looked at the "Changes" to see why such an old stable module would need changed ... when i looked at the source, i didn't understand how the change worked, it looked like you were ignoring $_ altogether because of "return unless @_;"... sure enough, it doesn't look like it does work.
here's what and install prints out...
Running install for module Text::Shellwords
Running make for L/LD/LDS/Text-Shellwords-1.01.tar.gz
Fetching with LWP:
ftp://archive.progeny.com/CPAN/authors/id/L/LD/LDS/Text-Shellwords-1.01.tar.gz
CPAN: MD5 loaded ok
Fetching with LWP:
ftp://archive.progeny.com/CPAN/authors/id/L/LD/LDS/CHECKSUMS
Checksum for /root/.cpan/sources/authors/id/L/LD/LDS/Text-Shellwords-1.01.tar.gz
ok
gzip: stdout: Broken pipe
Scanning cache /root/.cpan/build for sizes
Text-Shellwords-1.01/
Text-Shellwords-1.01/Shellwords.pm
Text-Shellwords-1.01/README
Text-Shellwords-1.01/Changes
Text-Shellwords-1.01/test.pl
Text-Shellwords-1.01/Makefile.PL
Text-Shellwords-1.01/MANIFEST
CPAN.pm: Going to build L/LD/LDS/Text-Shellwords-1.01.tar.gz
Checking if your kit is complete...
Looks good
Writing Makefile for Text::Shellwords
cp Shellwords.pm blib/lib/Text/Shellwords.pm
Manifying blib/man3/Text::Shellwords.3pm
/usr/bin/make -- OK
Running make test
PERL_DL_NONLAZY=1 /usr/local/bin/perl -Iblib/arch -Iblib/lib -I/usr/lib/perl/5.6
.1 -I/usr/share/perl/5.6.1 test.pl
1..7
# Running under perl version 5.006001 for linux
# Current time local: Mon Jun 16 23:43:01 2003
# Current time GMT: Tue Jun 17 06:43:01 2003
# Using Test.pm version 1.24
ok 1
ok 2
ok 3
ok 4
ok 5
not ok 6
# Test 6 got: '' (test.pl at line 23)
# Expected: 'one,two,three'
# test.pl line 23 is: ok(join(',',shellwords),'one,two,three');
ok 7
/usr/bin/make test -- OK
Running make install
Installing /usr/local/share/perl/5.6.1/Text/Shellwords.pm
Installing /usr/local/man/man3/Text::Shellwords.3pm
Writing /usr/local/lib/perl/5.6.1/auto/Text/Shellwords/.packlist
Appending installation info to /usr/local/lib/perl/5.6.1/perllocal.pod
/usr/bin/make install -- OK
...I'm not sure why it installed anyway.